[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31808: [SPARK-34713][SQL] Fix group by CreateStruct with ExtractValue

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31808:
URL: https://github.com/apache/spark/pull/31808#discussion_r592140758



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -448,6 +453,10 @@ case class GetMapValue(
 
   override def toString: String = s"$child[$key]"
   override def sql: String = s"${child.sql}[${key.sql}]"
+  override def name: Option[String] = key match {
+    case NonNullLiteral(s, StringType) => Some(s.toString)
+    case _ => None

Review comment:
       Oh, do we have a valid case for this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org