You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/21 12:50:00 UTC
[GitHub] [cloudstack-primate] andrijapanicsb commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering
andrijapanicsb commented on a change in pull request #600:
URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r474675600
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
Sliders are certainly much more usefulthan the up/down arrows (makes clicking from 1MB to 8192 a bit of pain :) )
(assuming it doesn't complicate things due to difference between min/max "values" for the slider - as we custom unconstrained and constrained offerings (need to know min/max values for the slider)
##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -21,31 +21,20 @@
<a-row>
<a-col :md="colContraned" :lg="colContraned">
<a-form-item
- :label="this.$t('label.cpunumber')"
+ :label="$t('label.cpunumber')"
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
- <a-slider
- :min="minCpu"
- :max="maxCpu"
- v-model="cpuNumberInputValue"
- @change="($event) => updateComputeCpuNumber($event)"
- />
Review comment:
Sliders are certainly much more useful than the up/down arrows (makes clicking from 1MB to 8192 a bit of pain :) )
(assuming it doesn't complicate things due to difference between min/max "values" for the slider - as we custom unconstrained and constrained offerings (need to know min/max values for the slider)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org