You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sergei Ivanov (JIRA)" <ji...@codehaus.org> on 2011/12/13 17:32:02 UTC
[jira] (MCHECKSTYLE-169) Suppressions property is incorrectly set
if suppressions file is on classpath
Sergei Ivanov created MCHECKSTYLE-169:
-----------------------------------------
Summary: Suppressions property is incorrectly set if suppressions file is on classpath
Key: MCHECKSTYLE-169
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-169
Project: Maven 2.x Checkstyle Plugin
Issue Type: Bug
Affects Versions: 2.8
Reporter: Sergei Ivanov
If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-169) Suppressions property is incorrectly set
if suppressions file is on classpath
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=290591#comment-290591 ]
Dennis Lundberg commented on MCHECKSTYLE-169:
---------------------------------------------
Can you give a sample project that we can use to test this?
> Suppressions property is incorrectly set if suppressions file is on classpath
> -----------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-169
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-169
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.8
> Reporter: Sergei Ivanov
>
> If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-169) Suppressions property is incorrectly set
if suppressions file is on classpath
Posted by "Sergei Ivanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=307773#comment-307773 ]
Sergei Ivanov commented on MCHECKSTYLE-169:
-------------------------------------------
Please, please!
> Suppressions property is incorrectly set if suppressions file is on classpath
> -----------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-169
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-169
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.8
> Reporter: Sergei Ivanov
> Attachments: MCHECKSTYLE-169-bugfix.patch, MCHECKSTYLE-169-it.patch
>
>
> If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-169) Suppressions property is incorrectly set
if suppressions file is on classpath
Posted by "Sergei Ivanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergei Ivanov updated MCHECKSTYLE-169:
--------------------------------------
Attachment: MCHECKSTYLE-169-bugfix.patch
MCHECKSTYLE-169-it.patch
Hello Dennis,
Attached are an integration test for the described problem and a patch that fixes it. I wanted to add a couple of additional integration tests to check for regressions, but ran out of spare time. Please review and integrate into the next release if deemed suitable. The patch is against the SVN trunk for the plugin.
Thank you.
> Suppressions property is incorrectly set if suppressions file is on classpath
> -----------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-169
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-169
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.8
> Reporter: Sergei Ivanov
> Attachments: MCHECKSTYLE-169-bugfix.patch, MCHECKSTYLE-169-it.patch
>
>
> If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-169) Suppressions property is incorrectly set
if suppressions file is on classpath
Posted by "Sergei Ivanov (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=305468#comment-305468 ]
Sergei Ivanov commented on MCHECKSTYLE-169:
-------------------------------------------
Any chance of the attached patch being integrated into 2.10?
> Suppressions property is incorrectly set if suppressions file is on classpath
> -----------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-169
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-169
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.8
> Reporter: Sergei Ivanov
> Attachments: MCHECKSTYLE-169-bugfix.patch, MCHECKSTYLE-169-it.patch
>
>
> If checkstyle plugin loads suppressions file from its classpath, and the checkstyle configuration contains suppression filter with a property placeholder, that property is not expanded because an incorrect path is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira