You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gaborgsomogyi (via GitHub)" <gi...@apache.org> on 2025/07/25 14:28:51 UTC

[PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

gaborgsomogyi opened a new pull request, #26833:
URL: https://github.com/apache/flink/pull/26833

   ## What is the purpose of the change
   
   At the moment when Flink uses the legacy YAML format then `add_jars` and `add_classpaths` are behaving wrong (stores value in YAML format instead of `;` separated). In this PR I've fixed it in a way that when legacy YAML format used then the mentioned function not just reading the values according to this format but also storing it that way.
   
   ## Brief change log
   
   `add_jars` and `add_classpaths` with legacy YAML format.
   
   ## Verifying this change
   
   Enhanced automated tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi merged PR #26833:
URL: https://github.com/apache/flink/pull/26833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3118110258

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1635d18ed717e5239766f04748ffd8cc6d624837",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1635d18ed717e5239766f04748ffd8cc6d624837",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1635d18ed717e5239766f04748ffd8cc6d624837 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3121436708

   Seems like the failures remained the same so testing test run with a dummy change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3121488561

   Thanks for helping me out! Acting accordingly...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3121491865

   Just for the reference the 1.19 tests passed and here the changes tests also passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3118245460

   cc @ferenc-csaky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3120167015

   Seems like unrelated test failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-38143][python] Fix pyflink flat YAML based config support [flink]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #26833:
URL: https://github.com/apache/flink/pull/26833#issuecomment-3121479581

   The current Python state on `release-1.20` is already broken ([Azure run for the last upstream commit has the same error](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=68987&view=results)). This change has a green CI on 1.19 (https://github.com/apache/flink/pull/26834), so the current CI failure is orthogonal to this change.
   
   I suggest to merge this and open a follow-up ticket to fix the already existing problem on 1.20.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org