You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/04/07 01:57:48 UTC

[GitHub] [iceberg] yittg opened a new pull request, #4521: Flink 1.13: Fix parquet readers for array data

yittg opened a new pull request, #4521:
URL: https://github.com/apache/iceberg/pull/4521

   Apply fix #4432 to Flink version 1.13


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx commented on pull request #4521: Flink 1.13: Fix parquet readers for array data

Posted by GitBox <gi...@apache.org>.
openinx commented on PR #4521:
URL: https://github.com/apache/iceberg/pull/4521#issuecomment-1091164680

   The failure case is : 
   
   ```
   org.apache.iceberg.flink.TestFlinkUpsert > testPrimaryKeyFieldsAtEndOfTableSchema[catalogName=testhadoop, baseNamespace=default, format=PARQUET, isStreaming=true] FAILED
       java.lang.AssertionError: 
       Expecting:
         [+I[3, bbb, 2022-03-01], +I[1, aaa, 2022-03-01]]
       to contain exactly in any order:
         [+I[2, aaa, 2022-03-01], +I[3, bbb, 2022-03-01]]
       elements not found:
         [+I[2, aaa, 2022-03-01]]
       and elements not expected:
         [+I[1, aaa, 2022-03-01]]
           at org.apache.iceberg.flink.TestHelpers.assertRows(TestHelpers.java:137)
           at org.apache.iceberg.flink.TestFlinkUpsert.testPrimaryKeyFieldsAtEndOfTableSchema(TestFlinkUpsert.java:262)
   ```
   
   Let's discuss there : https://github.com/apache/iceberg/issues/4515 . 
   
   This PR looks good to me overall.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] yittg commented on pull request #4521: Flink 1.13: Fix parquet readers for array data

Posted by GitBox <gi...@apache.org>.
yittg commented on PR #4521:
URL: https://github.com/apache/iceberg/pull/4521#issuecomment-1091167403

   Thanks @openinx.
   
   I touched this failure case twice recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx merged pull request #4521: Flink 1.13: Fix parquet readers for array data

Posted by GitBox <gi...@apache.org>.
openinx merged PR #4521:
URL: https://github.com/apache/iceberg/pull/4521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org