[PR] fix(table): retain ref head snapshots in expire snapshots (#1829) [iceberg-go]

["badalprasadsingh (via GitHub)" <gi...@apache.org>]

badalprasadsingh opened a new pull request, #1842:
URL: https://github.com/apache/iceberg-go/pull/1842

   ### Description
   
   Closes #1829 
   
   Earlier, `ExpireSnapshots` only protected _main_'s head. With `history.expire.min-snapshots-to-keep=0`, a _non-main_ branch or _tag_ head older than max-snapshot-age-ms was expired and its ref silently dropped, deleting data files. 
   
   From now on, every retained _ref_'s head is kept. Both ancestor walks reuse `AncestorsOf`, which also terminates on cyclic metadata. 
   
   ### Testing
   Added regression tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] fix(table): retain ref head snapshots in expire snapshots (#1829) [iceberg-go]

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade merged PR #1842:
URL: https://github.com/apache/iceberg-go/pull/1842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org