You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@steitz.com> on 2008/06/07 22:24:19 UTC

[math] Multiple regression "addData" methods

I think these methods should be named "setData."  They have a different 
contract from "addData" in SimpleRegression, which does not replace 
observations that have previously been added.  If there are no 
objections, I will make that change.

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [math] Multiple regression "addData" methods

Posted by Mauro Talevi <ma...@aquilonia.org>.
Phil Steitz wrote:
> I think these methods should be named "setData."  They have a different 
> contract from "addData" in SimpleRegression, which does not replace 
> observations that have previously been added.  If there are no 
> objections, I will make that change.

Yes - It makes sense to be consistent wrt to SimpleRegression.  The 
addData was left to mirror as much as possible the simple case but it is 
true that the effect is different.

Alternatively, an even more expression name could be "newData" (and 
"newX/YSampleData" correspondingly in the abstract method) so it's clear 
that the user is resetting previously set data.

Another alternative is to introduce a clear() method.

My personal preference would probably be for "newData" but any of the 3 
options is fine.

Cheers


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [math] Multiple regression "addData" methods

Posted by Luc Maisonobe <Lu...@free.fr>.
Phil Steitz a écrit :
> I think these methods should be named "setData."  They have a different
> contract from "addData" in SimpleRegression, which does not replace
> observations that have previously been added.  If there are no
> objections, I will make that change.

+1 from me

Luc

> 
> Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org