You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2016/08/30 07:30:33 UTC

[10/12] git commit: [flex-falcon] [refs/heads/develop] - [BUGFIX] Extra check to cover potential case where generateBindableImpl is run against Object.as native class

[BUGFIX] Extra check to cover potential case where generateBindableImpl is run against Object.as native class


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/ab5c6f49
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/ab5c6f49
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/ab5c6f49

Branch: refs/heads/develop
Commit: ab5c6f49c5035befb635935bc170d9ffd54f8695
Parents: 26cd027
Author: greg-dove <gr...@gmail.com>
Authored: Mon Aug 29 16:56:41 2016 +1200
Committer: greg-dove <gr...@gmail.com>
Committed: Mon Aug 29 16:56:41 2016 +1200

----------------------------------------------------------------------
 .../compiler/internal/as/codegen/ClassDirectiveProcessor.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/ab5c6f49/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
----------------------------------------------------------------------
diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java b/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
index 0b1d882..35f447e 100644
--- a/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
+++ b/compiler/src/main/java/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
@@ -703,10 +703,10 @@ class ClassDirectiveProcessor extends DirectiveProcessor
 
     protected void generateBindableImpl()
     {
-            //  initially double-check that this class has not already been set to an
+            //  initially double-check that this class has not already been set to be an
             //  implicit subclass of EventDispatcher in this ClassDirectiveProcessor's constructor
             //  before the needsEventDispatcher check (which doesn't know about the implementation)
-            if(!this.superclassName.equals(BindableHelper.NAME_EVENT_DISPATCHER)
+            if((this.superclassName == null || !this.superclassName.equals(BindableHelper.NAME_EVENT_DISPATCHER))
                     && classDefinition.needsEventDispatcher(classScope.getProject()) )
             {
                 // Generate a EventDispatcher member, equivalent to: