[GitHub] [incubator-kvrocks] GoGim1 created a discussion: replace unique_ptr constructor with `MakeUnique` or `UniqueIterator`

[GitBox <gi...@apache.org>]

GitHub user GoGim1 created a discussion: replace unique_ptr constructor with `MakeUnique` or `UniqueIterator`

ref https://github.com/apache/incubator-kvrocks/pull/711#discussion_r913359020
ref https://github.com/apache/incubator-kvrocks/pull/703#discussion_r912320795

I noticed there are many places in the code base where used the unique_ptr constructor directly instead of using `MakeUnique` and `UniqueIterator`. Do we need to replace them all? I wonder if this fix is worth PRs as it is too trivial and doesn't seem to bring performance benefits.

GitHub link: https://github.com/apache/incubator-kvrocks/discussions/719

----
This is an automatically sent email for dev@kvrocks.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@kvrocks.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice added a comment to the discussion: replace unique_ptr constructor with `MakeUnique` or `UniqueIterator`

[GitBox <gi...@apache.org>]

GitHub user PragmaTwice added a comment to the discussion: replace unique_ptr constructor with `MakeUnique` or `UniqueIterator`

I think it is OK to replace them to keep a unified code style.

GitHub link: https://github.com/apache/incubator-kvrocks/discussions/719#discussioncomment-3089791

----
This is an automatically sent email for dev@kvrocks.apache.org.
To unsubscribe, please send an email to: dev-unsubscribe@kvrocks.apache.org