[GitHub] [incubator-iceberg] rdblue edited a comment on issue #280: Add persistent IDs to partition fields

[GitBox <gi...@apache.org>]

rdblue edited a comment on issue #280: Add persistent IDs to partition fields
URL: https://github.com/apache/incubator-iceberg/issues/280#issuecomment-525451795
 
 
   > And also as TableMetadata knows how many fields are in partition, so can maintain the nextIDValue as well.
   
   The next partition field ID is the highest field ID in all of the table's partition specs +1. Once a partition spec is removed, we can reuse the ID. Alternatively, we can keep track of the last assigned ID, like we do for the table schema.
   
   > Also the TableMetadata#updatePartitionSpec should also use nextIDValue to pass to PartitionSpec.
   
   I think the spec's IDs will be assigned by the time that method is called because the partition spec passed in is already created.
   
   > Does modifying/dropping columns also needs to be taken care, I believe not?
   
   No. `updateSchema` already checks compatibility: https://github.com/apache/incubator-iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableMetadata.java#L284
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org