You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2026/09/07 12:01:55 UTC
[PR] Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container [skywalking-banyandb-helm]
mrproliu opened a new pull request, #72:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/72
…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container [skywalking-banyandb-helm]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu merged PR #72:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add an `env` list to the lifecycle sidecar, the backup sidecar and the restore init container [skywalking-banyandb-helm]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #72:
URL: https://github.com/apache/skywalking-banyandb-helm/pull/72#discussion_r3949619295
##########
chart/values.yaml:
##########
@@ -818,6 +821,9 @@ cluster:
## Lifecycle sidecar configuration for data pods
##
lifecycleSidecar:
+ ## @param cluster.data.nodeTemplate.lifecycleSidecar.env Environment variables for the lifecycle sidecar
+ ##
+ env: []
Review Comment:
The three new parameters are absent from `chart/values-lifecycle.yaml`, even though lifecycle users are directed to that values file. This leaves its backup, lifecycle, and restore sections out of sync with the default values and violates the values-file documentation convention in `AGENTS.md:29-30`. Please add the corresponding documented `env: []` entries there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org