[GitHub] [iceberg] liukun4515 edited a comment on pull request #1819: [WIP]SQL extension: expire snapshot

[GitBox <gi...@apache.org>]

liukun4515 edited a comment on pull request #1819:
URL: https://github.com/apache/iceberg/pull/1819#issuecomment-733405329


   > Also, per design doc, `older_than` is optional and should be defaulted to `System.currentTimeMillis()` if not set.
   > 
   > Then we can keep only a given number of snapshots:
   > 
   > ```
   > CALL catalog.schema.expire_snapshots(
   >   namespace => 'namespace_name',
   >   table => 'table_name',
   >   retain_last => 100
   > )
   > ```
   
   The the default `older_than`(`System.currentTime`) is a very dangerous.
   
   If don't give the `older_than` value, all the snapshots will be dropped.
   
   @chenjunjiedada 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org