You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by markhamstra <gi...@git.apache.org> on 2014/11/17 02:41:40 UTC
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
GitHub user markhamstra opened a pull request:
https://github.com/apache/spark/pull/3297
[SPARK-4436][SPARK-3624][BUILD] Debian packaging fixes
This makes the Spark jar as well as the datanucleus jars (and anything else in lib_managed/jars) available in the debian package at spark/lib. In addition to allowing HiveContext to work with a deb package built using -Phive, this incorporates the clean&simple-but-not-backward-compatible fix for SPARK-3624, which has been needed since Spark 1.0.0.
@JoshRosen @tzolov @pwendell @andrewor14
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markhamstra/spark SPARK-4436
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3297
----
commit 7b7a828de7393f474ec8976ff382311fb9ca0538
Author: Mark Hamstra <ma...@gmail.com>
Date: 2014-11-16T23:19:22Z
Added datanucleus jars to deb package
commit ad84b1b59ae8f531d45702b4dfad6b530730ad01
Author: Mark Hamstra <ma...@gmail.com>
Date: 2014-11-17T01:31:31Z
Debian packaging: spark/jars -> spark/lib
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-74152766
@markhamstra @srowen shall we get this into 1.3 since it's not totally removed there, or just close this issue altogether?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-63254742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23446/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-74153550
I had assumed this wouldn't go in, but y'know it can't hurt if it fixes a problem I suppose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-63254740
[Test build #23446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23446/consoleFull) for PR 3297 at commit [`ad84b1b`](https://github.com/apache/spark/commit/ad84b1b59ae8f531d45702b4dfad6b530730ad01).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-73848852
Per SPARK-5727, I believe the outstanding Debian issues should be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-74174441
@markhamstra if we can resolve the merge conflict I'll merge it, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by mag- <gi...@git.apache.org>.
Github user mag- commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-63286730
If we're fixing this, could we also change permissions for bin/sbin files?
like in this commit:
https://github.com/mag-/spark/commit/3d71761863c715e163c24efd21bc3408ca71d2ff
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-74157814
Agreed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-63250958
[Test build #23446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23446/consoleFull) for PR 3297 at commit [`ad84b1b`](https://github.com/apache/spark/commit/ad84b1b59ae8f531d45702b4dfad6b530730ad01).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4436][SPARK-3624][BUILD] Debian packagi...
Posted by kno10 <gi...@git.apache.org>.
Github user kno10 commented on the pull request:
https://github.com/apache/spark/pull/3297#issuecomment-92696538
Apparently the .jar files are no longer included in the package with that change...
This line seems to be missing:
https://github.com/kno10/bigtop/commit/038c5184329da132252957d5ca5ab44dbe9fd980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org