[GitHub] [hive] aasha commented on a change in pull request #883: HIVE-22736 Support multiple encryption zones in replication

[GitBox <gi...@apache.org>]

aasha commented on a change in pull request #883: HIVE-22736 Support multiple encryption zones in replication
URL: https://github.com/apache/hive/pull/883#discussion_r370151392
 
 

 ##########
 File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/ReplChangeManager.java
 ##########
 @@ -138,15 +149,18 @@ private ReplChangeManager(Configuration conf) throws MetaException {
       if (!inited) {
         if (MetastoreConf.getBoolVar(conf, ConfVars.REPLCMENABLED)) {
           ReplChangeManager.enabled = true;
-          ReplChangeManager.cmroot = new Path(MetastoreConf.getVar(conf, ConfVars.REPLCMDIR));
           ReplChangeManager.conf = conf;
 
+          //Create default cm root
+          Path cmroot = new Path(MetastoreConf.getVar(conf, ConfVars.REPLCMDIR));
           FileSystem cmFs = cmroot.getFileSystem(conf);
           // Create cmroot with permission 700 if not exist
           if (!cmFs.exists(cmroot)) {
             cmFs.mkdirs(cmroot);
             cmFs.setPermission(cmroot, new FsPermission("700"));
           }
+          cmRootMapping.put(NO_ENCRYPTION, cmroot);
 
 Review comment:
   This is for REPLCMDIR. This will always be unencrypted. Encryption cm directory we have separated. If there is any unencrypted path for which recycle is called, we will use this. Else we will create a cm for that zone

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org