You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 13:05:04 UTC

[GitHub] [flink] shuttie edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

shuttie edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString
URL: https://github.com/apache/flink/pull/10358#issuecomment-561581868
 
 
   @pnowojski as for large strings, this implementation is also looking quite nice:
   ```
   master:
   
   Benchmark                                 (lengthStr)   (type)   Mode  Cnt    Score     Error   Units
   StringSerializationBenchmark.stringRead          1024    ascii  thrpt   30  769.067 ±   9.803  ops/ms
   StringSerializationBenchmark.stringRead          1024  russian  thrpt   30  293.632 ±  22.269  ops/ms
   StringSerializationBenchmark.stringRead          1024  chinese  thrpt   30  260.280 ±   0.768  ops/ms
   StringSerializationBenchmark.stringRead          4096    ascii  thrpt   30  144.826 ±  21.883  ops/ms
   StringSerializationBenchmark.stringRead          4096  russian  thrpt   30   74.815 ±   1.635  ops/ms
   StringSerializationBenchmark.stringRead          4096  chinese  thrpt   30   67.306 ±   2.223  ops/ms
   StringSerializationBenchmark.stringRead         16384    ascii  thrpt   30   53.418 ±   0.589  ops/ms
   StringSerializationBenchmark.stringRead         16384  russian  thrpt   30   20.338 ±   0.374  ops/ms
   StringSerializationBenchmark.stringRead         16384  chinese  thrpt   30   17.313 ±   0.126  ops/ms
   StringSerializationBenchmark.stringRead         65536    ascii  thrpt   30   10.042 ±   1.524  ops/ms
   StringSerializationBenchmark.stringRead         65536  russian  thrpt   30    5.055 ±   0.018  ops/ms
   StringSerializationBenchmark.stringRead         65536  chinese  thrpt   30    4.342 ±   0.037  ops/ms
   StringSerializationBenchmark.stringWrite         1024    ascii  thrpt   30  771.981 ± 160.013  ops/ms
   StringSerializationBenchmark.stringWrite         1024  russian  thrpt   30  456.973 ±   1.563  ops/ms
   StringSerializationBenchmark.stringWrite         1024  chinese  thrpt   30  250.321 ±   0.953  ops/ms
   StringSerializationBenchmark.stringWrite         4096    ascii  thrpt   30  106.595 ±   0.496  ops/ms
   StringSerializationBenchmark.stringWrite         4096  russian  thrpt   30   70.336 ±   0.157  ops/ms
   StringSerializationBenchmark.stringWrite         4096  chinese  thrpt   30   49.363 ±   0.236  ops/ms
   StringSerializationBenchmark.stringWrite        16384    ascii  thrpt   30   26.593 ±   0.099  ops/ms
   StringSerializationBenchmark.stringWrite        16384  russian  thrpt   30   17.362 ±   0.077  ops/ms
   StringSerializationBenchmark.stringWrite        16384  chinese  thrpt   30   13.487 ±   1.534  ops/ms
   StringSerializationBenchmark.stringWrite        65536    ascii  thrpt   30   11.295 ±   2.286  ops/ms
   StringSerializationBenchmark.stringWrite        65536  russian  thrpt   30    5.805 ±   0.753  ops/ms
   StringSerializationBenchmark.stringWrite        65536  chinese  thrpt   30    3.707 ±   0.326  ops/ms
   
   this PR:
   
   Benchmark                                 (lengthStr)   (type)   Mode  Cnt    Score   Error   Units
   StringSerializationBenchmark.stringRead          1024    ascii  thrpt   30   70.249 ± 0.458  ops/ms
   StringSerializationBenchmark.stringRead          1024  russian  thrpt   30   36.628 ± 0.091  ops/ms
   StringSerializationBenchmark.stringRead          1024  chinese  thrpt   30   24.181 ± 0.094  ops/ms
   StringSerializationBenchmark.stringRead          4096    ascii  thrpt   30   17.698 ± 0.313  ops/ms
   StringSerializationBenchmark.stringRead          4096  russian  thrpt   30    9.086 ± 0.064  ops/ms
   StringSerializationBenchmark.stringRead          4096  chinese  thrpt   30    6.048 ± 0.024  ops/ms
   StringSerializationBenchmark.stringRead         16384    ascii  thrpt   30    4.382 ± 0.024  ops/ms
   StringSerializationBenchmark.stringRead         16384  russian  thrpt   30    2.270 ± 0.008  ops/ms
   StringSerializationBenchmark.stringRead         16384  chinese  thrpt   30    1.515 ± 0.007  ops/ms
   StringSerializationBenchmark.stringRead         65536    ascii  thrpt   30    1.109 ± 0.005  ops/ms
   StringSerializationBenchmark.stringRead         65536  russian  thrpt   30    0.567 ± 0.002  ops/ms
   StringSerializationBenchmark.stringRead         65536  chinese  thrpt   30    0.379 ± 0.002  ops/ms
   StringSerializationBenchmark.stringWrite         1024    ascii  thrpt   30  175.745 ± 1.416  ops/ms
   StringSerializationBenchmark.stringWrite         1024  russian  thrpt   30   52.724 ± 0.231  ops/ms
   StringSerializationBenchmark.stringWrite         1024  chinese  thrpt   30   45.952 ± 5.209  ops/ms
   StringSerializationBenchmark.stringWrite         4096    ascii  thrpt   30   42.445 ± 0.288  ops/ms
   StringSerializationBenchmark.stringWrite         4096  russian  thrpt   30   22.000 ± 0.320  ops/ms
   StringSerializationBenchmark.stringWrite         4096  chinese  thrpt   30   13.603 ± 1.681  ops/ms
   StringSerializationBenchmark.stringWrite        16384    ascii  thrpt   30    7.062 ± 0.042  ops/ms
   StringSerializationBenchmark.stringWrite        16384  russian  thrpt   30    3.532 ± 0.022  ops/ms
   StringSerializationBenchmark.stringWrite        16384  chinese  thrpt   30    2.527 ± 0.015  ops/ms
   StringSerializationBenchmark.stringWrite        65536    ascii  thrpt   30    1.741 ± 0.007  ops/ms
   StringSerializationBenchmark.stringWrite        65536  russian  thrpt   30    0.893 ± 0.002  ops/ms
   StringSerializationBenchmark.stringWrite        65536  chinese  thrpt   30    0.635 ± 0.004  ops/ms
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services