[GitHub] [beam] tvalentyn commented on a change in pull request #11738: [BEAM-9936] Create SDK harness containers with Python 3.8

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #11738:
URL: https://github.com/apache/beam/pull/11738#discussion_r427466990



##########
File path: .test-infra/jenkins/job_PostCommit_Python_ValidatesContainer_Dataflow.groovy
##########
@@ -39,5 +39,7 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_Py_ValCont',
     shell('cd ' + commonJobProperties.checkoutDir + ' && bash sdks/python/container/run_validatescontainer.sh python35')
     shell('cd ' + commonJobProperties.checkoutDir + ' && bash sdks/python/container/run_validatescontainer.sh python36')
     shell('cd ' + commonJobProperties.checkoutDir + ' && bash sdks/python/container/run_validatescontainer.sh python37')
+    // TODO: Turn on ValidatesContainer tests on Python 3.8 once BEAM-9754 is resolved.

Review comment:
       Let's mention it as: TODO(BEAM-9754): ...

##########
File path: sdks/python/container/run_validatescontainer.sh
##########
@@ -69,8 +71,13 @@ elif [[ $1 == "python37" ]]; then
   CONTAINER_PROJECT="sdks:python:container:py37"  # Use this to build container by Gradle.
   GRADLE_PY3_FLAG="-Ppython3"   # Use this in Gradle command.
   PY_INTERPRETER="python3.7"    # Use this in virtualenv command.
+elif [[ $1 == "python38" ]]; then
+  IMAGE_NAME="${IMAGE_PREFIX}python3.8_sdk"    # Use this to create CONTAINER_IMAGE variable.
+  CONTAINER_PROJECT="sdks:python:container:py38"  # Use this to build container by Gradle.
+  GRADLE_PY3_FLAG="-Ppython3"   # Use this in Gradle command.

Review comment:
       `  GRADLE_PY3_FLAG="-Ppython3"   # Use this in Gradle command.` - is this still required? I don't quite understand what it does... Do you see any difference if we remove it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org