You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:00:59 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2005: Fix note_syscall_leave_s to avoid unaligned access

xiaoxiang781216 commented on a change in pull request #2005:
URL: https://github.com/apache/incubator-nuttx/pull/2005#discussion_r506604786



##########
File path: include/nuttx/sched_note.h
##########
@@ -286,9 +286,9 @@ struct note_syscall_enter_s
 
 struct note_syscall_leave_s
 {
-  struct note_common_s nsc_cmn; /* Common note parameters */
-  uintptr_t nsc_result;         /* Result of the system call */
-  uint8_t nsc_nr;               /* System call number */
+  struct note_common_s nsc_cmn;          /* Common note parameters */
+  uint8_t nsc_nr;                        /* System call number */
+  uint8_t nsc_result[sizeof(uintptr_t)]; /* Result of the system call */

Review comment:
       should we fix nsp_spinlock in note_spinlock_s too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org