You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "PsiACE (via GitHub)" <gi...@apache.org> on 2025/09/30 16:52:33 UTC
[PR] feat(bindings/python): add region detect [opendal]
PsiACE opened a new pull request, #6607:
URL: https://github.com/apache/opendal/pull/6607
> I'm back with my codex.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The Python binding for S3 required users to supply the region explicitly even though the Rust core already exposes `S3::detect_region`. This caused configuration errors for Python users who forgot the region.
Aligning the binding with the core auto-detect behaviour removes that friction.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Inject a lightweight region cache in the Python binding so constructors call the Rust detect_region when the region is absent and reuse the result for the same (endpoint, bucket) pair.
- Add a pytest covering the new auto-detect path and verifying the cache is hit on subsequent constructions.
# Are there any user-facing changes?
Python users targeting S3 no longer need to provide the region manually when the endpoint makes it deducible or `detect_region` can resolve it.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): add region detect [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6607:
URL: https://github.com/apache/opendal/pull/6607#issuecomment-3353171852
> This PR is worse than I expected. I now realize that working around it from the Python side isn’t a good idea. Can we handle this on the Rust side instead? For example, defer the initialization until the first API call. For example, we can use a once_cell that gets filled by `detect_region` when the user hasn’t provided it.
This is also good for users to use `Operator::from_uri("s3://bucket/path")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core/s3): auto detect region [opendal]
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE closed pull request #6607: feat(core/s3): auto detect region
URL: https://github.com/apache/opendal/pull/6607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): add region detect [opendal]
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on PR #6607:
URL: https://github.com/apache/opendal/pull/6607#issuecomment-3353178792
> This PR is worse than I expected. I now realize that working around it from the Python side isn’t a good idea. Can we handle this on the Rust side instead? For example, defer the initialization until the first API call. For example, we can use a once_cell that gets filled by `detect_region` when the user hasn’t provided it.
I shall attend to this matter myself tomorrow morning. 🤗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(bindings/python): add region detect [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6607:
URL: https://github.com/apache/opendal/pull/6607#issuecomment-3353169714
This PR is worse than I expected. I now realize that working around it from the Python side isn’t a good idea. Can we handle this on the Rust side instead? For example, defer the initialization until the first API call. I can manage if we use a once_cell that gets filled by `detect_region` when the user hasn’t provided it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core/s3): auto detect region [opendal]
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on PR #6607:
URL: https://github.com/apache/opendal/pull/6607#issuecomment-3554343058
Let me close it, and I'll come back with a new PR over the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org