You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ju...@apache.org on 2025/09/24 17:27:02 UTC

(superset) branch master updated: chore(sqllab): remove unused json param (#35065)

This is an automated email from the ASF dual-hosted git repository.

justinpark pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 0defcb604b chore(sqllab): remove unused json param (#35065)
0defcb604b is described below

commit 0defcb604bc1bf960e9c27741524a963a5e716aa
Author: JUST.in DO IT <ju...@airbnb.com>
AuthorDate: Wed Sep 24 10:26:55 2025 -0700

    chore(sqllab): remove unused json param (#35065)
---
 superset-frontend/src/SqlLab/actions/sqlLab.js                           | 1 -
 .../Datasource/components/DatasourceEditor/DatasourceEditor.jsx          | 1 -
 superset-frontend/src/database/types.ts                                  | 1 -
 superset/sqllab/schemas.py                                               | 1 -
 superset/views/sql_lab/schemas.py                                        | 1 -
 5 files changed, 5 deletions(-)

diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.js b/superset-frontend/src/SqlLab/actions/sqlLab.js
index 4d0091b405..2c6a6e47b5 100644
--- a/superset-frontend/src/SqlLab/actions/sqlLab.js
+++ b/superset-frontend/src/SqlLab/actions/sqlLab.js
@@ -338,7 +338,6 @@ export function runQuery(query, runPreviewOnly) {
     const postPayload = {
       client_id: query.id,
       database_id: query.dbId,
-      json: true,
       runAsync: query.runAsync,
       catalog: query.catalog,
       schema: query.schema,
diff --git a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
index 30b499bed5..a5ad47aefa 100644
--- a/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
+++ b/superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx
@@ -740,7 +740,6 @@ class DatasourceEditor extends PureComponent {
     this.props.runQuery({
       client_id: this.props.clientId,
       database_id: this.state.datasource.database.id,
-      json: true,
       runAsync: false,
       catalog: this.state.datasource.catalog,
       schema: this.state.datasource.schema,
diff --git a/superset-frontend/src/database/types.ts b/superset-frontend/src/database/types.ts
index 8abfeca5d6..e3aea236c9 100644
--- a/superset-frontend/src/database/types.ts
+++ b/superset-frontend/src/database/types.ts
@@ -20,7 +20,6 @@
 export interface QueryExecutePayload {
   client_id: string;
   database_id: number;
-  json: boolean;
   runAsync: boolean;
   catalog: string | null;
   schema: string;
diff --git a/superset/sqllab/schemas.py b/superset/sqllab/schemas.py
index 1e1d492b7c..ce86a990c5 100644
--- a/superset/sqllab/schemas.py
+++ b/superset/sqllab/schemas.py
@@ -63,7 +63,6 @@ class ExecutePayloadSchema(Schema):
     templateParams = fields.String(allow_none=True)  # noqa: N815
     tmp_table_name = fields.String(allow_none=True)
     select_as_cta = fields.Boolean(allow_none=True)
-    json = fields.Boolean(allow_none=True)
     runAsync = fields.Boolean(allow_none=True)  # noqa: N815
     expand_data = fields.Boolean(allow_none=True)
 
diff --git a/superset/views/sql_lab/schemas.py b/superset/views/sql_lab/schemas.py
index ea184cb397..c9f57d7c02 100644
--- a/superset/views/sql_lab/schemas.py
+++ b/superset/views/sql_lab/schemas.py
@@ -30,6 +30,5 @@ class SqlJsonPayloadSchema(Schema):
     templateParams = fields.String(allow_none=True)  # noqa: N815
     tmp_table_name = fields.String(allow_none=True)
     select_as_cta = fields.Boolean(allow_none=True)
-    json = fields.Boolean(allow_none=True)
     runAsync = fields.Boolean(allow_none=True)  # noqa: N815
     expand_data = fields.Boolean(allow_none=True)