You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/18 14:11:09 UTC
[GitHub] [beam] kamilwu opened a new pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
kamilwu opened a new pull request #12612:
URL: https://github.com/apache/beam/pull/12612
Add Python GBK Load Tests for streaming on Dataflow. Cases 1, 2, 4 and 5 are temporarily excluded because their execution time is too long.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679096177
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-675502147
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r475467063
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
##########
@@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def loadTestConfigurations = { datasetName ->
+// TODO(BEAM-10774): Skipping some cases because they are too slow.
+def STREAMING_TESTS_TO_SKIP = [1, 2, 4, 5]
Review comment:
Thanks, an argument that @kkucharc made in PR#12435 is convincing. I'll exclude those cases by using the job_name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-675512260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r475707404
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
##########
@@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def loadTestConfigurations = { datasetName ->
+// TODO(BEAM-10774): Skipping some cases because they are too slow.
+def STREAMING_TESTS_TO_SKIP = [1, 2, 4, 5]
+
+def loadTestConfigurations = { mode, datasetName ->
[
[
title : 'GroupByKey Python Load test: 2GB of 10B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-1-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-1-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_1',
- influx_measurement : 'python_batch_gbk_1',
+ metrics_table : "python_dataflow_${mode}_gbk_1",
+ influx_measurement : "python_${mode}_gbk_1",
input_options : '\'{"num_records": 200000000,' +
'"key_size": 1,' +
'"value_size": 9}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: 2GB of 100B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-2-' + now,
+ job_name : 'load-tests-python-dataflow-${mode}-gbk-2-' + now,
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_2',
- influx_measurement : 'python_batch_gbk_2',
+ metrics_table : 'python_dataflow_${mode}_gbk_2',
+ influx_measurement : 'python_${mode}_gbk_2',
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: 2GB of 100kB records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-3-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-3-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_3',
- influx_measurement : 'python_batch_gbk_3',
+ metrics_table : "python_dataflow_${mode}_gbk_3",
+ influx_measurement : "python_${mode}_gbk_3",
input_options : '\'{"num_records": 20000,' +
'"key_size": 10000,' +
'"value_size": 90000}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: fanout 4 times with 2GB 10-byte records total',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-4-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-4-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_4',
- influx_measurement : 'python_batch_gbk_4',
+ metrics_table : "python_dataflow_${mode}_gbk_4",
+ influx_measurement : "python_${mode}_gbk_4",
input_options : '\'{"num_records": 5000000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 4,
- num_workers : 5,
- autoscaling_algorithm: "NONE"
+ num_workers : 16,
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: fanout 8 times with 2GB 10-byte records total',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-5-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-5-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_5',
- influx_measurement : 'python_batch_gbk_5',
+ metrics_table : "python_dataflow_${mode}_gbk_5",
+ influx_measurement : "python_${mode}_gbk_5",
input_options : '\'{"num_records": 2500000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 8,
- num_workers : 5,
- autoscaling_algorithm: "NONE"
+ num_workers : 16,
+ autoscaling_algorithm: 'NONE',
]
],
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
+ .withIndex().collectMany { test, i ->
+ mode == 'streaming' && STREAMING_TESTS_TO_SKIP.contains(i + 1) ? []: [test]
+ }
+}
+
+def addStreamingOptions(test) {
+ test.pipelineOptions << [streaming: null, experiments: 'use_runner_v2',
+ enable_streaming_engine: null ]
+}
Review comment:
I removed `--enable_streaming_engine`, since it is now being added automatically when using `use_runner_v2`: https://github.com/apache/beam/pull/12585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-675511335
Run Load Tests Python GBK Dataflow Batch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679096177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-677508599
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-677526631
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-680743583
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-677578802
R: @tysonjh Could you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679208026
Run Load Tests Python GBK Dataflow Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r475520818
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy
##########
@@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName ->
pipelineOptions: [
project : 'apache-beam-testing',
region : 'us-central1',
- job_name : 'load-tests-python-dataflow-batch-gbk-7-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-7-${now}",
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_7',
- influx_measurement : 'python_batch_gbk_7',
+ metrics_table : "python_dataflow_${mode}_gbk_7",
+ influx_measurement : "python_${mode}_gbk_7",
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90,' +
'"num_hot_keys": 10,' +
'"hot_key_fraction": 1}\'',
- fanout : 1,
iterations : 4,
+ fanout : 1,
num_workers : 5,
- autoscaling_algorithm: 'NONE'
+ autoscaling_algorithm: 'NONE',
]
]
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
}
-def batchLoadTestJob = { scope, triggeringContext ->
- scope.description('Runs Python GBK reiterate load tests on Dataflow runner in batch mode')
- commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
+def addStreamingOptions(test) {
+ test.pipelineOptions << [streaming: null, experiments: 'use_runner_v2',
+ enable_streaming_engine: null ]
+}
+def loadTestJob = { scope, triggeringContext, mode ->
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
- for (testConfiguration in loadTestConfigurations(datasetName)) {
- loadTestsBuilder.loadTest(scope, testConfiguration.title, testConfiguration.runner, CommonTestProperties.SDK.PYTHON_37, testConfiguration.pipelineOptions, testConfiguration.test)
- }
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.PYTHON_37,
+ loadTestConfigurations(mode, datasetName), 'GBK reiterate', mode)
}
-CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch', 'H 14 * * *', this) {
- additionalPipelineArgs = [
- influx_db_name: InfluxDBCredentialsHelper.InfluxDBDatabaseName,
- influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostname,
- ]
- batchLoadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT)
-}
+CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch',
+ 'H 14 * * *', this) {
Review comment:
Ideally, each test suite (GBK, ParDo, IO tests, etc.) should has its own, unique time in order no to flood Jenkins with many tests that are triggered at the same time. When adding a new test suite, a contributor has to take a look at what time slots are already occupied and avoid using them.
I think this is not documented. I'll add some information here: https://cwiki.apache.org/confluence/display/BEAM/Contribution+Testing+Guide#ContributionTestingGuide-TestsofCoreApacheBeamOperations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679036617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679036724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-675511770
Run Load Tests Python GBK Dataflow Streaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679207648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679064210
Run Python2_PVR_Flink PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r475520818
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy
##########
@@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName ->
pipelineOptions: [
project : 'apache-beam-testing',
region : 'us-central1',
- job_name : 'load-tests-python-dataflow-batch-gbk-7-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-7-${now}",
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_7',
- influx_measurement : 'python_batch_gbk_7',
+ metrics_table : "python_dataflow_${mode}_gbk_7",
+ influx_measurement : "python_${mode}_gbk_7",
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90,' +
'"num_hot_keys": 10,' +
'"hot_key_fraction": 1}\'',
- fanout : 1,
iterations : 4,
+ fanout : 1,
num_workers : 5,
- autoscaling_algorithm: 'NONE'
+ autoscaling_algorithm: 'NONE',
]
]
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
}
-def batchLoadTestJob = { scope, triggeringContext ->
- scope.description('Runs Python GBK reiterate load tests on Dataflow runner in batch mode')
- commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
+def addStreamingOptions(test) {
+ test.pipelineOptions << [streaming: null, experiments: 'use_runner_v2',
+ enable_streaming_engine: null ]
+}
+def loadTestJob = { scope, triggeringContext, mode ->
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
- for (testConfiguration in loadTestConfigurations(datasetName)) {
- loadTestsBuilder.loadTest(scope, testConfiguration.title, testConfiguration.runner, CommonTestProperties.SDK.PYTHON_37, testConfiguration.pipelineOptions, testConfiguration.test)
- }
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.PYTHON_37,
+ loadTestConfigurations(mode, datasetName), 'GBK reiterate', mode)
}
-CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch', 'H 14 * * *', this) {
- additionalPipelineArgs = [
- influx_db_name: InfluxDBCredentialsHelper.InfluxDBDatabaseName,
- influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostname,
- ]
- batchLoadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT)
-}
+CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch',
+ 'H 14 * * *', this) {
Review comment:
Ideally, each test suite (GBK, ParDo, IO tests, etc.) should has its own, unique time in order no to flood Jenkins with many tests that are triggered at the same time. When adding a new test suite, a contributor has to take a look at what time slots are already occupied and avoid using them.
I think this is not documented. I'll add some information here: https://cwiki.apache.org/confluence/display/BEAM/Contribution+Testing+Guide#ContributionTestingGuide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
tysonjh commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r474830190
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
##########
@@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def loadTestConfigurations = { datasetName ->
+// TODO(BEAM-10774): Skipping some cases because they are too slow.
+def STREAMING_TESTS_TO_SKIP = [1, 2, 4, 5]
+
+def loadTestConfigurations = { mode, datasetName ->
[
[
title : 'GroupByKey Python Load test: 2GB of 10B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-1-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-1-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_1',
- influx_measurement : 'python_batch_gbk_1',
+ metrics_table : "python_dataflow_${mode}_gbk_1",
+ influx_measurement : "python_${mode}_gbk_1",
input_options : '\'{"num_records": 200000000,' +
'"key_size": 1,' +
'"value_size": 9}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: 2GB of 100B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-2-' + now,
+ job_name : 'load-tests-python-dataflow-${mode}-gbk-2-' + now,
Review comment:
```suggestion
job_name : "load-tests-python-dataflow-${mode}-gbk-2-${now}",
```
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
##########
@@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def loadTestConfigurations = { datasetName ->
+// TODO(BEAM-10774): Skipping some cases because they are too slow.
+def STREAMING_TESTS_TO_SKIP = [1, 2, 4, 5]
+
+def loadTestConfigurations = { mode, datasetName ->
[
[
title : 'GroupByKey Python Load test: 2GB of 10B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-1-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-1-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_1',
- influx_measurement : 'python_batch_gbk_1',
+ metrics_table : "python_dataflow_${mode}_gbk_1",
+ influx_measurement : "python_${mode}_gbk_1",
input_options : '\'{"num_records": 200000000,' +
'"key_size": 1,' +
'"value_size": 9}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: 2GB of 100B records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-2-' + now,
+ job_name : 'load-tests-python-dataflow-${mode}-gbk-2-' + now,
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_2',
- influx_measurement : 'python_batch_gbk_2',
+ metrics_table : 'python_dataflow_${mode}_gbk_2',
+ influx_measurement : 'python_${mode}_gbk_2',
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: 2GB of 100kB records',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-3-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-3-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_3',
- influx_measurement : 'python_batch_gbk_3',
+ metrics_table : "python_dataflow_${mode}_gbk_3",
+ influx_measurement : "python_${mode}_gbk_3",
input_options : '\'{"num_records": 20000,' +
'"key_size": 10000,' +
'"value_size": 90000}\'',
iterations : 1,
fanout : 1,
num_workers : 5,
- autoscaling_algorithm: "NONE"
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: fanout 4 times with 2GB 10-byte records total',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-4-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-4-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_4',
- influx_measurement : 'python_batch_gbk_4',
+ metrics_table : "python_dataflow_${mode}_gbk_4",
+ influx_measurement : "python_${mode}_gbk_4",
input_options : '\'{"num_records": 5000000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 4,
- num_workers : 5,
- autoscaling_algorithm: "NONE"
+ num_workers : 16,
+ autoscaling_algorithm: 'NONE',
]
],
[
title : 'GroupByKey Python Load test: fanout 8 times with 2GB 10-byte records total',
test : 'apache_beam.testing.load_tests.group_by_key_test',
runner : CommonTestProperties.Runner.DATAFLOW,
pipelineOptions: [
- job_name : 'load-tests-python-dataflow-batch-gbk-5-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-5-${now}",
project : 'apache-beam-testing',
region : 'us-central1',
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_5',
- influx_measurement : 'python_batch_gbk_5',
+ metrics_table : "python_dataflow_${mode}_gbk_5",
+ influx_measurement : "python_${mode}_gbk_5",
input_options : '\'{"num_records": 2500000,' +
'"key_size": 10,' +
'"value_size": 90}\'',
iterations : 1,
fanout : 8,
- num_workers : 5,
- autoscaling_algorithm: "NONE"
+ num_workers : 16,
+ autoscaling_algorithm: 'NONE',
]
],
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
+ .withIndex().collectMany { test, i ->
+ mode == 'streaming' && STREAMING_TESTS_TO_SKIP.contains(i + 1) ? []: [test]
+ }
+}
+
+def addStreamingOptions(test) {
+ test.pipelineOptions << [streaming: null, experiments: 'use_runner_v2',
+ enable_streaming_engine: null ]
+}
Review comment:
Can you add a comment to explain what these settings are? It's unexpected to see that 'streaming: null' or 'enable_streaming_engine: null' somehow enables streaming, or why 'use_runner_v2' is required.
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy
##########
@@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName ->
pipelineOptions: [
project : 'apache-beam-testing',
region : 'us-central1',
- job_name : 'load-tests-python-dataflow-batch-gbk-7-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-7-${now}",
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_7',
- influx_measurement : 'python_batch_gbk_7',
+ metrics_table : "python_dataflow_${mode}_gbk_7",
+ influx_measurement : "python_${mode}_gbk_7",
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90,' +
'"num_hot_keys": 10,' +
'"hot_key_fraction": 1}\'',
- fanout : 1,
iterations : 4,
+ fanout : 1,
num_workers : 5,
- autoscaling_algorithm: 'NONE'
+ autoscaling_algorithm: 'NONE',
]
]
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
}
-def batchLoadTestJob = { scope, triggeringContext ->
- scope.description('Runs Python GBK reiterate load tests on Dataflow runner in batch mode')
- commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
+def addStreamingOptions(test) {
Review comment:
Same here, please add a comment.
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python_reiterate.groovy
##########
@@ -58,43 +58,47 @@ def loadTestConfigurations = { datasetName ->
pipelineOptions: [
project : 'apache-beam-testing',
region : 'us-central1',
- job_name : 'load-tests-python-dataflow-batch-gbk-7-' + now,
+ job_name : "load-tests-python-dataflow-${mode}-gbk-7-${now}",
temp_location : 'gs://temp-storage-for-perf-tests/loadtests',
publish_to_big_query : true,
metrics_dataset : datasetName,
- metrics_table : 'python_dataflow_batch_gbk_7',
- influx_measurement : 'python_batch_gbk_7',
+ metrics_table : "python_dataflow_${mode}_gbk_7",
+ influx_measurement : "python_${mode}_gbk_7",
input_options : '\'{"num_records": 20000000,' +
'"key_size": 10,' +
'"value_size": 90,' +
'"num_hot_keys": 10,' +
'"hot_key_fraction": 1}\'',
- fanout : 1,
iterations : 4,
+ fanout : 1,
num_workers : 5,
- autoscaling_algorithm: 'NONE'
+ autoscaling_algorithm: 'NONE',
]
]
- ].each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ ]
+ .each { test -> test.pipelineOptions.putAll(additionalPipelineArgs) }
+ .each { test -> (mode != 'streaming') ?: addStreamingOptions(test) }
}
-def batchLoadTestJob = { scope, triggeringContext ->
- scope.description('Runs Python GBK reiterate load tests on Dataflow runner in batch mode')
- commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 240)
+def addStreamingOptions(test) {
+ test.pipelineOptions << [streaming: null, experiments: 'use_runner_v2',
+ enable_streaming_engine: null ]
+}
+def loadTestJob = { scope, triggeringContext, mode ->
def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
- for (testConfiguration in loadTestConfigurations(datasetName)) {
- loadTestsBuilder.loadTest(scope, testConfiguration.title, testConfiguration.runner, CommonTestProperties.SDK.PYTHON_37, testConfiguration.pipelineOptions, testConfiguration.test)
- }
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.PYTHON_37,
+ loadTestConfigurations(mode, datasetName), 'GBK reiterate', mode)
}
-CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch', 'H 14 * * *', this) {
- additionalPipelineArgs = [
- influx_db_name: InfluxDBCredentialsHelper.InfluxDBDatabaseName,
- influx_hostname: InfluxDBCredentialsHelper.InfluxDBHostname,
- ]
- batchLoadTestJob(delegate, CommonTestProperties.TriggeringContext.POST_COMMIT)
-}
+CronJobBuilder.cronJob('beam_LoadTests_Python_GBK_reiterate_Dataflow_Batch',
+ 'H 14 * * *', this) {
Review comment:
What's the methodology for picking the time to trigger these? Is it documented anywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679207946
Run Load Tests Python GBK Dataflow Batch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> Merging [#12612](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
==========================================
- Coverage 34.47% 34.33% -0.14%
==========================================
Files 684 692 +8
Lines 81483 81958 +475
Branches 9180 9264 +84
==========================================
+ Hits 28090 28144 +54
- Misses 52965 53391 +426
+ Partials 428 423 -5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
| [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
| [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
| [testing/load\_tests/load\_test\_metrics\_utils.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL2xvYWRfdGVzdF9tZXRyaWNzX3V0aWxzLnB5) | `34.98% <0.00%> (-1.39%)` | :arrow_down: |
| [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
| [pipeline.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
| [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
| [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
| [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
| [runners/common.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [094d06c...11a1a3b](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679032396
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> Merging [#12612](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/cfa448d121297398312d09c531258a72b413488b?el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
==========================================
- Coverage 34.47% 34.33% -0.14%
==========================================
Files 684 692 +8
Lines 81483 81958 +475
Branches 9180 9264 +84
==========================================
+ Hits 28090 28144 +54
- Misses 52965 53391 +426
+ Partials 428 423 -5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [typehints/typecheck\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVja190ZXN0X3B5My5weQ==) | `31.54% <0.00%> (-16.00%)` | :arrow_down: |
| [typehints/typecheck.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVjaGVjay5weQ==) | `29.44% <0.00%> (-6.18%)` | :arrow_down: |
| [utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `30.95% <0.00%> (-2.39%)` | :arrow_down: |
| [testing/load\_tests/load\_test\_metrics\_utils.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL2xvYWRfdGVzdF9tZXRyaWNzX3V0aWxzLnB5) | `34.98% <0.00%> (-1.39%)` | :arrow_down: |
| [runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==) | `33.81% <0.00%> (-0.87%)` | :arrow_down: |
| [pipeline.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cGlwZWxpbmUucHk=) | `22.04% <0.00%> (-0.28%)` | :arrow_down: |
| [options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `52.99% <0.00%> (-0.16%)` | :arrow_down: |
| [transforms/ptransform\_test.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtX3Rlc3QucHk=) | `18.37% <0.00%> (-0.09%)` | :arrow_down: |
| [transforms/core.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jb3JlLnB5) | `36.79% <0.00%> (-0.05%)` | :arrow_down: |
| [runners/common.py](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree#diff-cnVubmVycy9jb21tb24ucHk=) | `27.50% <0.00%> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/beam/pull/12612/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [094d06c...e6bbfe2](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679204422
Run Seed Job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu merged pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu merged pull request #12612:
URL: https://github.com/apache/beam/pull/12612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-677511359
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on a change in pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
tysonjh commented on a change in pull request #12612:
URL: https://github.com/apache/beam/pull/12612#discussion_r474840528
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Python.groovy
##########
@@ -22,119 +22,138 @@ import InfluxDBCredentialsHelper
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
-def loadTestConfigurations = { datasetName ->
+// TODO(BEAM-10774): Skipping some cases because they are too slow.
+def STREAMING_TESTS_TO_SKIP = [1, 2, 4, 5]
Review comment:
@kkucharc made a good point [here in PR#12435](https://github.com/apache/beam/pull/12435#discussion_r466648416) about using indices for ignoring tests. I'm more inclined towards the approach @kkucharc is taking by excluding using the job_name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679031190
# [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d2ef73e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12612 +/- ##
=========================================
Coverage ? 34.33%
=========================================
Files ? 692
Lines ? 81958
Branches ? 9264
=========================================
Hits ? 28144
Misses ? 53391
Partials ? 423
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=footer). Last update [d2ef73e...b1c9673](https://codecov.io/gh/apache/beam/pull/12612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679063372
@tysonjh Thanks! Could you verify my fixes before I merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu removed a comment on pull request #12612: [BEAM-10675] Add Python GBK Load Tests for streaming on Dataflow
Posted by GitBox <gi...@apache.org>.
kamilwu removed a comment on pull request #12612:
URL: https://github.com/apache/beam/pull/12612#issuecomment-679208026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org