You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/05 23:52:20 UTC

[GitHub] tysonnorris commented on a change in pull request #3507: allow use of string for controller id

tysonnorris commented on a change in pull request #3507: allow use of string for controller id
URL: https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193256190
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
 ##########
 @@ -22,7 +22,20 @@ import spray.json.DefaultJsonProtocol
 case class InstanceId(val instance: Int, name: Option[String] = None) {
   def toInt: Int = instance
 }
-
+case class StringInstanceId(instance: String) {
 
 Review comment:
   Currently InvokerSupervision does update by index - where the index is directly mapped from the instance id using:
   ```
   status = status.updated(instance.toInt, new InvokerHealth(instance, currentState))
   ```
   I think this would have to change to use a `Map` instead of `IndexedSeq`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services