You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mbektchiev <gi...@git.apache.org> on 2015/08/27 12:32:37 UTC
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/289
CB-6698 Fix directory resolution of framework with parent
Due to a refactoring after the original implementation the installation of plugins containing frameworks with parent=true were broken.
This pull request fixes the paths and adds two unit tests for such frameworks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-lib bektchiev/CB-6698
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #289
----
commit 999db66cb5b4d79b598812e279f7b69e08946464
Author: Martin Bektchiev <ma...@telerik.com>
Date: 2015-08-27T09:44:45Z
CB-6698 Fix directory resolution of framework with parent
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-150069617
It looks good to me. It is essentially just fixing `parent=true`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by mbektchiev <gi...@git.apache.org>.
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795
@stevengill Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-162125224
Merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by mbektchiev <gi...@git.apache.org>.
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-155330596
Rebased on latest master and now tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by mbektchiev <gi...@git.apache.org>.
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-159824863
@stevengill do you think this can be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6698 Fix directory resolution of fram...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-152079604
Failing tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org