You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/07 00:17:05 UTC

[GitHub] [pulsar] merlimat commented on pull request #17948: [issue-17931][improve][java-client]Cache SchemaHash

merlimat commented on PR #17948:
URL: https://github.com/apache/pulsar/pull/17948#issuecomment-1270865354

   One more change could be: 
   
   ```java
    public SchemaHash getSchemaHash() {
           return schemaHash == null ? SchemaHash.of(new byte[0], null) : schemaHash;
       }
   ```
   
   to avoid the `new byte[0]` allocation and instead passing a `null`;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org