You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2020/05/15 02:41:36 UTC
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15921
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
IMPALA-9749: ASAN builds should not run FE tests.
https://gerrit.cloudera.org/#/c/15778/ inadvertently changed the
behaviour of ASAN builds to to run FE tests. This change skips
FE tests if it is an ASAN build.
Testing:
Ran private parametrized job with ASAN.
Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15921/1
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 21:08:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5888/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 21:44:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh@41
PS3, Line 41: # Parametrized Test Options
: # Run FE Tests
: : ${FE_TEST:=true}
: # Run Backend Tests
: : ${BE_TEST:=true}
> This is a standalone script. People can run this in their development envir
Yeah of course, this is happening because we previously required both CLUSTER_TEST and FE_TEST for these to run, so they weren't running in sharded jobs when one shard had CLUSTER_TEST and the other had FE_TEST.
I switched it to just require CLUSTER_TEST, but if we instead just require FE_TEST this ASAN issue is fixed.
Downsides are that you'll have to have the backend fully built and the minicluster started to run the FE tests, which we didn't used to require but which this script expects anyways, and you'll have to restart impala after these tests run with the same params as on line 166
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 16:04:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh@41
PS3, Line 41: # Parametrized Test Options
: # Run FE Tests
: : ${FE_TEST:=true}
: # Run Backend Tests
: : ${BE_TEST:=true}
This is a standalone script. People can run this in their development environment, and we run this outside of buildall.sh. Environment variables need to come from bin/impala-config.sh or they need to be optionally set by the user / enclosing script. If coming from the user / enclosing script, there needs to be a default value here. (Also, this script will fail if we try to access an unbound variable.)
Separately, it is a bit awkward to expect someone to know to set an environment variable to a particular value for a particular configuration. This is true for some configurations today, but ideally it wouldn't be needed.
I think one temporary fix for this is to lump those frontend custom cluster tests in with FE_TEST rather than CLUSTER_TEST for now. FE_TEST already doesn't work on ASAN, so any existing users would have an ok experience.
Longer term, it would be nice to detect ASAN correctly. We detect ASAN in our pytests:
https://github.com/apache/impala/blob/master/tests/common/environ.py#L141
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 23:08:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2020 15:49:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4:
(1 comment)
Made the changes suggested by Thomas. I'm started a private-parametrized asan build. I will wait for the job to finish.
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/15921/3/bin/run-all-tests.sh@41
PS3, Line 41: # Parametrized Test Options
: # Run FE Tests
: : ${FE_TEST:=true}
: # Run Backend Tests
: : ${BE_TEST:=true}
> Yeah of course, this is happening because we previously required both CLUST
As per Thomas's suggestion above, I moved the FE custom cluster tests to the branch in FE_TESTS = true. Also added restart script from L166 after the tests.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 21:43:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5848/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 17:09:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
IMPALA-9749: ASAN builds should not run FE tests.
https://gerrit.cloudera.org/#/c/15778/ inadvertently changed the
behaviour of ASAN builds to to run FE tests. After this change,
FE custom cluster tests run immediately after other FE tests
when FE_TEST is true.
Testing:
Ran private parametrized job with ASAN.
Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
---
M bin/run-all-tests.sh
1 file changed, 25 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15921/5
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6076/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 03:36:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4:
The precommits as well as ASAN private parameterized jobs have passed. Will merge after a +2.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 May 2020 14:53:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 2:
Wondering if just using CMAKE_BUILD_TYPE it sufficient.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 15:27:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6172/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2020 01:05:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
IMPALA-9749: ASAN builds should not run FE tests.
https://gerrit.cloudera.org/#/c/15778/ inadvertently changed the
behaviour of ASAN builds to to run FE tests. After this change,
FE custom cluster tests require only CLUSTER_TESTS to be true.
Testing:
Ran private parametrized job with ASAN.
Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
---
M bin/run-all-tests.sh
1 file changed, 12 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15921/4
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@206
PS4, Line 206: if [[ "$CODE_COVERAGE" == true ]]; then
> I don't think this works - it means that you'll be running the FE custom cl
Done.
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@211
PS4, Line 211: MVN_ARGS_TEMP=$MVN_ARGS
> You should refactor this out into its own function in this file so that we'
Done
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2020 00:22:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@206
PS4, Line 206: if ! "${IMPALA_HOME}/bin/mvn-quiet.sh" -fae test ${MVN_ARGS}; then
I don't think this works - it means that you'll be running the FE custom cluster tests in the same maven run as the rest of the FE tests, but I don't think it's guaranteed that they'll run at the end, so they may interfere with the rest of the FE tests. And we still want the regular FE tests to run against s3.
I think you'll need to do two separate calls to mvn-quiet, the first to do the regular FE tests and the second to do the FE custom cluster tests.
http://gerrit.cloudera.org:8080/#/c/15921/4/bin/run-all-tests.sh@211
PS4, Line 211: run-step "Starting Impala cluster" start-impala-cluster.log \
You should refactor this out into its own function in this file so that we're not duplicating it
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2020 16:44:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 May 2020 02:58:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 17:09:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6100/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 16:33:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5848/
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 22:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 16:56:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
IMPALA-9749: ASAN builds should not run FE tests.
https://gerrit.cloudera.org/#/c/15778/ inadvertently changed the
behaviour of ASAN builds to to run FE tests. After this change,
FE custom cluster tests run immediately after other FE tests
when FE_TEST is true.
Testing:
Ran private parametrized job with ASAN.
Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Reviewed-on: http://gerrit.cloudera.org:8080/15921
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 25 insertions(+), 16 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2020 05:36:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5914/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2020 00:22:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
IMPALA-9749: ASAN builds should not run FE tests.
https://gerrit.cloudera.org/#/c/15778/ inadvertently changed the
behaviour of ASAN builds to to run FE tests. This change skips
FE tests if it is an ASAN build.
Testing:
Ran private parametrized job with ASAN.
Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/15921/3
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 2:
Looks like the environment variable is "CMAKE_BUILD_TYPE" on our GVD hence it could not recognize "BUILD_TYPE".
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2020 18:33:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6129/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 May 2020 22:26:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 )
Change subject: IMPALA-9749: ASAN builds should not run FE tests.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5859/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c469a20032bdc1f4f0bb3938d9f1c50163c99a
Gerrit-Change-Number: 15921
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2020 15:42:30 +0000
Gerrit-HasComments: No