[jira] Commented: (OFBIZ-1927) Add currency code to the key of the PartyRate entity

["Hans Bakker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625642#action_12625642 ] 

Hans Bakker commented on OFBIZ-1927:
------------------------------------

The following question about this change was raised by David: (answer by: >>)
What's more, this should have been explicitly discussed on the mailing list so that others could more easily share their thoughts and opinions.
>> david, this Isue is now open for about a week now and nobody reacted.


For example, why not just have different RateTypes for the different currencies, why do we need it explicitly on the 
entity? And even if we need or want it on the entity, why does it have to be part of the primary key?

>> This rate is like a product price. We quote to our foreign customers in foreign currency. These customers will normally not accept a rate change because of a change currency exchange rates. So we search this party rate table for the rate in the required currency, create the invoice from that, and for local accounting convert that invoice to our currency here using the exchange rate table.
So the currency need to be part of the key otherwise we cannot store different rates for the same ratetype.


> Add currency code to the key of the PartyRate entity
> ----------------------------------------------------
>
>                 Key: OFBIZ-1927
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1927
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: workeffort
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>             Fix For: SVN trunk
>
>
> Rate of a person is like a price, we need to be able to specify it in several different currencies.
> I order to do that i propose to add the field 'currencyUomId' to the key of the PartyRate entity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.