You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Afsalmc (via GitHub)" <gi...@apache.org> on 2023/11/22 09:37:51 UTC

[I] Generated queries contain `LIMIT` even though `allow_limit_clause = False` in dbEngineSpec. [superset]

Afsalmc opened a new issue, #26068:
URL: https://github.com/apache/superset/issues/26068

   A clear and concise description of what the bug is.
   
   #### How to reproduce the bug
   
   1. Go to 'Sqllab'
   2. Click on 'SEE TABLE SCHEMA'
   3. Scroll down to any schema and click it to preview the table schema.
   4. Click the Copy select statement button near table name.
   5. In select query you can see LIMIT keyword. 
   
   ### Expected results
   
   Generate query with TOP or anything other than LIMIT since allow_limit_clause is false.
   
   ### Actual results
   
   Query with LIMIT keyword.
   
   #### Screenshots
   
   ![image](https://github.com/apache/superset/assets/48438931/3fd45c9b-d974-4fad-98ec-947c0dac07da)
   
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version:
   - superset version: `3.0.1`
   - python version: `3.10`
   - node.js version: `v18.12.1`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!`
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Generated queries contain `LIMIT` even though `allow_limit_clause = False` in dbEngineSpec. [superset]

Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida closed issue #26068: Generated queries contain `LIMIT` even though  `allow_limit_clause = False` in dbEngineSpec.
URL: https://github.com/apache/superset/issues/26068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Generated queries contain `LIMIT` even though `allow_limit_clause = False` in dbEngineSpec. [superset]

Posted by "weikhor (via GitHub)" <gi...@apache.org>.
weikhor commented on issue #26068:
URL: https://github.com/apache/superset/issues/26068#issuecomment-1939382652

   I do not  think 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Generated queries contain `LIMIT` even though `allow_limit_clause = False` in dbEngineSpec. [superset]

Posted by "Afsalmc (via GitHub)" <gi...@apache.org>.
Afsalmc commented on issue #26068:
URL: https://github.com/apache/superset/issues/26068#issuecomment-1826328872

   @michael-s-molina @betodealmeida May I know in the code where it is adding limit 100 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org