You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ni...@apache.org on 2013/09/06 12:06:20 UTC
[2/2] git commit: Make libxml2 the configuration default XML parser
(so it should get a bit of test-driving).
Make libxml2 the configuration default XML parser
(so it should get a bit of test-driving).
Separate micro-commit so it's an easy distinction we can confine
to trunk even if the new code makes it into a release as an option
before it's well-tested.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/57fcef17
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/57fcef17
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/57fcef17
Branch: refs/heads/master
Commit: 57fcef17e1ef5020d475d3c8c71d71c6a7c7c337
Parents: 2184cc8
Author: Nick Kew <nk...@qualys.com>
Authored: Fri Sep 6 11:01:36 2013 +0100
Committer: Nick Kew <nk...@qualys.com>
Committed: Fri Sep 6 11:01:36 2013 +0100
----------------------------------------------------------------------
build/xml.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/57fcef17/build/xml.m4
----------------------------------------------------------------------
diff --git a/build/xml.m4 b/build/xml.m4
index d342814..fc342a9 100644
--- a/build/xml.m4
+++ b/build/xml.m4
@@ -31,9 +31,9 @@ AC_DEFUN([TS_CHECK_XML], [
elif test "$withval" = "libxml2" ; then
TS_CHECK_XML_LIBXML2
elif test "x$withval" = "x" ; then
- TS_CHECK_XML_EXPAT
+ TS_CHECK_XML_LIBXML2
if test "$enable_xml" = "no"; then
- TS_CHECK_XML_LIBXML2
+ TS_CHECK_XML_EXPAT
fi
else
AC_MSG_ERROR([Unrecognised --with-xml option])
Re: [2/2] git commit: Make libxml2 the configuration default XML parser (so it should get a bit of test-driving).
Posted by Bryan Call <bc...@yahoo-inc.com>.
It looks like some of the m4 files incorrectly implement the AC_ARG_WITH when there is no argument. Looking at the autoconf manual the 4th argument should be the block to run if there is no action set (e.g. no --with-xml on the configure). This was included inside of the 3rd argument previously and this was the part that was failing on the builds, because it was not being executed.
The second problem was using AC_MSG_ERROR instead of AC_MSG_WARN for the xml2 check and it would fail/stop if xml2 was not found.
autoconf section 15.2:
http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/External-Software.html#External-Software
-Bryan
On Sep 7, 2013, at 8:25 PM, James Peach <jp...@apache.org> wrote:
> On Sep 7, 2013, at 5:00 PM, Nick Kew <ni...@apache.org> wrote:
>
>>
>> On 7 Sep 2013, at 01:35, Nick Kew wrote:
>>
>>>> Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
>>
>> Somewhat to my surprise, I've failed to find any platform where
>> the build doesn't work out-of-the-box[1].
>
> Bryan made 2 commits to this yesterday. Maybe that's the complete fix?
>
> At any rate, the build farm is healthy now :)
>
>> It also correctly
>> finds and uses expat when I manually move the libxml2
>> headers so configure failed to find them.
>>
>> Are you working from a clean repo, did you run autoreconf,
>> could there be something lurking from outside /trunk/?
>> If not, what platform, and how is your libxml2 laid out?
>>
>> I'd be reluctant to commit a lot of extra debug to trunk!
>>
>> [1] Except for needing to feed it a working PCRE path on Mac.
>>
>> --
>> Nick Kew
>
Re: [2/2] git commit: Make libxml2 the configuration default XML parser (so it should get a bit of test-driving).
Posted by James Peach <jp...@apache.org>.
On Sep 7, 2013, at 5:00 PM, Nick Kew <ni...@apache.org> wrote:
>
> On 7 Sep 2013, at 01:35, Nick Kew wrote:
>
>>> Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
>
> Somewhat to my surprise, I've failed to find any platform where
> the build doesn't work out-of-the-box[1].
Bryan made 2 commits to this yesterday. Maybe that's the complete fix?
At any rate, the build farm is healthy now :)
> It also correctly
> finds and uses expat when I manually move the libxml2
> headers so configure failed to find them.
>
> Are you working from a clean repo, did you run autoreconf,
> could there be something lurking from outside /trunk/?
> If not, what platform, and how is your libxml2 laid out?
>
> I'd be reluctant to commit a lot of extra debug to trunk!
>
> [1] Except for needing to feed it a working PCRE path on Mac.
>
> --
> Nick Kew
Re: [2/2] git commit: Make libxml2 the configuration default XML parser (so it should get a bit of test-driving).
Posted by Nick Kew <ni...@apache.org>.
On 7 Sep 2013, at 01:35, Nick Kew wrote:
>> Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
Somewhat to my surprise, I've failed to find any platform where
the build doesn't work out-of-the-box[1]. It also correctly
finds and uses expat when I manually move the libxml2
headers so configure failed to find them.
Are you working from a clean repo, did you run autoreconf,
could there be something lurking from outside /trunk/?
If not, what platform, and how is your libxml2 laid out?
I'd be reluctant to commit a lot of extra debug to trunk!
[1] Except for needing to feed it a working PCRE path on Mac.
--
Nick Kew
Re: [2/2] git commit: Make libxml2 the configuration default XML
parser (so it should get a bit of test-driving).
Posted by Nick Kew <ni...@apache.org>.
On Fri, 6 Sep 2013 14:51:56 -0600
Leif Hedstrom <zw...@apache.org> wrote:
> On Sep 6, 2013, at 4:06 AM, niq@apache.org wrote:
>
> > Make libxml2 the configuration default XML parser
> > (so it should get a bit of test-driving).
> >
> > Separate micro-commit so it's an easy distinction we can confine
> > to trunk even if the new code makes it into a release as an option
> > before it's well-tested.
>
>
> Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
Heh. I guess I should've left the expat default, at least
for a while. If you specify
--with-xml=expat
it'll call the old expat-detection code, which I haven't changed.
But if you don't specify any --with-xml option, it should try
both before giving that error. If it doesn't, it's a bug in my M4.
> checking for existence of /usr/lib64/tclConfig.sh... loading
> checking "For XML parser"... configure: error: An XML parser (expat or libxml2) is required.
Damn. Guess we could use some temporary debug so you get
a trace of what it tried.
I should find time to revisit it over the weekend.
--
Nick Kew
Re: [2/2] git commit: Make libxml2 the configuration default XML parser (so it should get a bit of test-driving).
Posted by Leif Hedstrom <zw...@apache.org>.
On Sep 6, 2013, at 4:06 AM, niq@apache.org wrote:
> Make libxml2 the configuration default XML parser
> (so it should get a bit of test-driving).
>
> Separate micro-commit so it's an easy distinction we can confine
> to trunk even if the new code makes it into a release as an option
> before it's well-tested.
Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
-- Leif
checking for existence of /usr/lib64/tclConfig.sh... loading
checking "For XML parser"... configure: error: An XML parser (expat or libxml2) is required.
Re: [2/2] git commit: Make libxml2 the configuration default XML parser (so it should get a bit of test-driving).
Posted by Leif Hedstrom <zw...@apache.org>.
On Sep 6, 2013, at 4:06 AM, niq@apache.org wrote:
> Make libxml2 the configuration default XML parser
> (so it should get a bit of test-driving).
>
> Separate micro-commit so it's an easy distinction we can confine
> to trunk even if the new code makes it into a release as an option
> before it's well-tested.
Something in these commits breaks the builds completely. I have both expat and libxml2 installed (with dev packages), and it doesn't detect either. Same problem (I think) on all build bots (they all fail as far as I can tell?).
-- Leif
checking for existence of /usr/lib64/tclConfig.sh... loading
checking "For XML parser"... configure: error: An XML parser (expat or libxml2) is required.