[GitHub] [iceberg] yyanyy commented on a change in pull request #2159: AWS: Fail writes fast when S3OutputStream encountered error in async …

[GitBox <gi...@apache.org>]

yyanyy commented on a change in pull request #2159:
URL: https://github.com/apache/iceberg/pull/2159#discussion_r567132505



##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/S3OutputStreamTest.java
##########
@@ -133,6 +135,65 @@ public void testAbortMultipart() {
     }
   }
 
+  @Test(expected = IllegalStateException.class)

Review comment:
       Nit: can we do `AssertHelpers.assertThrows(<message>, IllegalStateException.class, () -> stream.write(1));` in these test cases instead of `expected` to check against exception message, to ensure it's the same exception being thrown as expected? 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org