You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/22 07:53:47 UTC

[GitHub] [cloudstack] rhtyd opened a new pull request #4336: vmware: while plugging in nics get existing sorted nic devices

rhtyd opened a new pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336


   In large environments, with VR having multiple nics when plugging in
   nic, it must get existing nics by sorted device ID otherwise it may
   cause incorrect nic plugging/order.
   
   Fixes #4246
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696649491


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696566436


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696735009


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696649214


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696649214


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696566819






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696581788






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696649214






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696733878


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696676236


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-697287982


   ping - can you review @DaanHoogland @shwstppr @Spaceman1984 @Pearl1594 @davidjumani and others


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696566436






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696661338


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2065


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696566819


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-697138047


   <b>Trillian test result (tid-2837)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47672 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4336-t2837-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 80 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3871.07 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3871.10 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 0.01 | test_vpc_redundant.py
   ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.01 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696661338






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696566436


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696661338






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696691442


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2066


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696675652


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4336: vmware: while plugging in nics get existing sorted nic devices

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4336:
URL: https://github.com/apache/cloudstack/pull/4336#issuecomment-696581788


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2062


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org