You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2025/02/24 17:32:33 UTC
(spark) branch master updated: [SPARK-50692][SQL] Add the LPAD and RPAD pushdown support for H2
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new ea15a953e818 [SPARK-50692][SQL] Add the LPAD and RPAD pushdown support for H2
ea15a953e818 is described below
commit ea15a953e818eec9f1d1c4b24a2fc376c27dba6b
Author: beliefer <be...@163.com>
AuthorDate: Mon Feb 24 09:32:20 2025 -0800
[SPARK-50692][SQL] Add the LPAD and RPAD pushdown support for H2
### What changes were proposed in this pull request?
This PR proposes to add the `LPAD` and `RPAD` pushdown support for H2.
### Why are the changes needed?
https://github.com/apache/spark/pull/49325 added the support for `RPAD` pushdown.
H2 as a built-in JDBC dialect for the test purpose, should add the `LPAD` and `RPAD` pushdown support for H2.
### Does this PR introduce _any_ user-facing change?
'Yes'.
Spark will supports pushdown for `LPAD` and `RPAD` for H2.
### How was this patch tested?
GA>
### Was this patch authored or co-authored using generative AI tooling?
'No'.
Closes #50068 from beliefer/SPARK-50692.
Authored-by: beliefer <be...@163.com>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
.../src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala | 2 +-
.../src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala b/sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
index 0d9dc88451cc..10d45081d361 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
@@ -52,7 +52,7 @@ private[sql] case class H2Dialect() extends JdbcDialect with NoLegacyJDBCError {
"POWER", "SQRT", "FLOOR", "CEIL", "ROUND", "SIN", "SINH", "COS", "COSH", "TAN",
"TANH", "COT", "ASIN", "ACOS", "ATAN", "ATAN2", "DEGREES", "RADIANS", "SIGN",
"PI", "SUBSTRING", "UPPER", "LOWER", "TRANSLATE", "TRIM", "MD5", "SHA1", "SHA2",
- "BIT_LENGTH", "CHAR_LENGTH", "CONCAT")
+ "BIT_LENGTH", "CHAR_LENGTH", "CONCAT", "RPAD", "LPAD")
override def isSupportedFunction(funcName: String): Boolean =
supportedFunctions.contains(funcName)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala b/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
index 1ba7ec78f8bd..692f7f95fba0 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
@@ -1922,6 +1922,16 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
checkFiltersRemoved(df8)
checkPushedInfo(df8, "[(CONCAT(NAME, ',', CAST(SALARY AS string))) = 'cathy,9000.00']")
checkAnswer(df8, Seq(Row(1, "cathy", 9000, 1200, false)))
+
+ val df9 = sql("SELECT * FROM h2.test.employee WHERE " +
+ "lpad(name, 5, '*') = '**amy'")
+ checkPushedInfo(df9, "[NAME IS NOT NULL, (LPAD(NAME, 5, '*')) = '**amy']")
+ checkAnswer(df9, Seq(Row(1, "amy", 10000, 1000, true)))
+
+ val df10 = sql("SELECT * FROM h2.test.employee WHERE " +
+ "rpad(name, 5, '*') = 'jen**'")
+ checkPushedInfo(df10, "[NAME IS NOT NULL, (RPAD(NAME, 5, '*')) = 'jen**']")
+ checkAnswer(df10, Seq(Row(6, "jen", 12000, 1200, true)))
}
test("scan with aggregate push-down: MAX AVG with filter and group by") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org