You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/25 02:27:37 UTC

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #11762: [C++] Make some clean up methods thread safe

BewareMyPower commented on a change in pull request #11762:
URL: https://github.com/apache/pulsar/pull/11762#discussion_r695343537



##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -129,7 +129,7 @@ ClientImpl::ClientImpl(const std::string& serviceUrl, const ClientConfiguration&
     }
 }
 
-ClientImpl::~ClientImpl() { shutdown(); }

Review comment:
       It will cause memory leak that the internal producers, consumers, `ClientConnection` and `ExecutorService` are not closed. I'll fix it,




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org