You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/10 17:27:00 UTC
[jira] [Commented] (NIFI-4597) Add a property to override HTTP
return code in ListenHTTP processor
[ https://issues.apache.org/jira/browse/NIFI-4597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247799#comment-16247799 ]
ASF GitHub Bot commented on NIFI-4597:
--------------------------------------
GitHub user sbouchex opened a pull request:
https://github.com/apache/nifi/pull/2266
NIFI-4597 Add a property to override HTTP return code in ListenHTTP processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X ] Have you written or updated unit tests to verify your changes?
- [ X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [X ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [X ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infovista/nifi NIFI-4597
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2266
----
commit 9352381c7ddbf51f8a055276ad442153c0650fe8
Author: sbouchex <sb...@infovista.com>
Date: 2017-11-10T17:25:14Z
NIFI-4597
Add a property to override HTTP return code in ListenHTTP processor
----
> Add a property to override HTTP return code in ListenHTTP processor
> -------------------------------------------------------------------
>
> Key: NIFI-4597
> URL: https://issues.apache.org/jira/browse/NIFI-4597
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.4.0
> Reporter: Sébastien Bouchex Bellomié
> Fix For: 1.5.0
>
>
> Current ListenHTTP processor is always returning 200 as HTTP return code but is some case, 204 may be required.
> I know that I may use the HandlerHttpRequest and HandlerHttpResponse couple but that's a bit overkill to this.
> The idea is to have a property (default value is 200) giving the ability to override the return code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)