You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/23 05:27:37 UTC

[cordova-windows] branch brodybits-uwp-only-test-wip0610 updated (490514a -> 7e8e847)

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch brodybits-uwp-only-test-wip0610
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


    from 490514a  remove Windows Phone 8.1 jsproj from template
     new 4ebfb89  add windows8.1 appxmanifest TODO comments
     new 7e8e847  remove Windows 8.1 jsproj from template

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/lib/update.js                    |   1 +
 template/CordovaApp.Windows.jsproj   | 106 -----------------------------------
 template/cordova/lib/AppxManifest.js |   2 +
 3 files changed, 3 insertions(+), 106 deletions(-)
 delete mode 100644 template/CordovaApp.Windows.jsproj


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-windows] 01/02: add windows8.1 appxmanifest TODO comments

Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0610
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 4ebfb89f21ddd982e9d88b28bc102a7ca402f02f
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Mon Dec 23 00:26:27 2019 -0500

    add windows8.1 appxmanifest TODO comments
---
 bin/lib/update.js                    | 1 +
 template/cordova/lib/AppxManifest.js | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/bin/lib/update.js b/bin/lib/update.js
index 2372703..5ef2ab9 100644
--- a/bin/lib/update.js
+++ b/bin/lib/update.js
@@ -43,6 +43,7 @@ module.exports.update = function (destinationDir, options) {
     var guid;
     var config = new ConfigParser(projectConfig);
 
+    // TODO find a better way to handle the guid than the old WP 8.1 appxmanifest (!!)
     // guid param is used only when adding a platform, and isn't saved anywhere.
     // The only place, where it is being persisted - phone/win10 appxmanifest file,
     // but since win10 introduced just recently, we can't rely on its manifest
diff --git a/template/cordova/lib/AppxManifest.js b/template/cordova/lib/AppxManifest.js
index b2b7e90..cf3f5c5 100644
--- a/template/cordova/lib/AppxManifest.js
+++ b/template/cordova/lib/AppxManifest.js
@@ -56,7 +56,9 @@ var MANIFESTS = {
     }
 };
 
+// TODO remove old Windows 8.1 & WP 8.1 appxmanifest files
 var SUBSTS = ['package.phone.appxmanifest', 'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+
 var TARGETS = ['windows', 'phone', 'all'];
 
 /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-windows] 02/02: remove Windows 8.1 jsproj from template

Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0610
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 7e8e8476f1c03b08879e89582e9fbd1ff8f7a7fa
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Mon Dec 23 00:27:02 2019 -0500

    remove Windows 8.1 jsproj from template
---
 template/CordovaApp.Windows.jsproj | 106 -------------------------------------
 1 file changed, 106 deletions(-)

diff --git a/template/CordovaApp.Windows.jsproj b/template/CordovaApp.Windows.jsproj
deleted file mode 100644
index 35c8f68..0000000
--- a/template/CordovaApp.Windows.jsproj
+++ /dev/null
@@ -1,106 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!--
-       Licensed to the Apache Software Foundation (ASF) under one
-       or more contributor license agreements.  See the NOTICE file
-       distributed with this work for additional information
-       regarding copyright ownership.  The ASF licenses this file
-       to you under the Apache License, Version 2.0 (the
-       "License"); you may not use this file except in compliance
-       with the License.  You may obtain a copy of the License at
-
-         http://www.apache.org/licenses/LICENSE-2.0
-
-       Unless required by applicable law or agreed to in writing,
-       software distributed under the License is distributed on an
-       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-       KIND, either express or implied.  See the License for the
-       specific language governing permissions and limitations
-       under the License.
--->
-<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <PropertyGroup>
-    <OutputPath>build\windows\$(Configuration)\$(Platform)\win8.1\</OutputPath>
-  <IntermediateOutputPath>build\windows\bld\</IntermediateOutputPath>
-  </PropertyGroup>
-  <ItemGroup Label="ProjectConfigurations">
-    <ProjectConfiguration Include="Debug|AnyCPU">
-      <Configuration>Debug</Configuration>
-      <Platform>AnyCPU</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Debug|ARM">
-      <Configuration>Debug</Configuration>
-      <Platform>ARM</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Debug|x64">
-      <Configuration>Debug</Configuration>
-      <Platform>x64</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Debug|x86">
-      <Configuration>Debug</Configuration>
-      <Platform>x86</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|AnyCPU">
-      <Configuration>Release</Configuration>
-      <Platform>AnyCPU</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|ARM">
-      <Configuration>Release</Configuration>
-      <Platform>ARM</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|x64">
-      <Configuration>Release</Configuration>
-      <Platform>x64</Platform>
-    </ProjectConfiguration>
-    <ProjectConfiguration Include="Release|x86">
-      <Configuration>Release</Configuration>
-      <Platform>x86</Platform>
-    </ProjectConfiguration>
-  </ItemGroup>
-  <PropertyGroup Label="Globals">
-    <ProjectGuid>58950fb6-2f93-4963-b9cd-637f83f3efbf</ProjectGuid>
-  </PropertyGroup>
-  <PropertyGroup Label="CordovaBuildParameters" Condition="'$(CordovaBundlePlatforms)' != ''">
-    <AppxBundle>Always</AppxBundle>
-    <AppxBundlePlatforms>$(CordovaBundlePlatforms)</AppxBundlePlatforms>
-  </PropertyGroup>
-  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
-  <PropertyGroup Condition="'$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '12.0'">
-    <VisualStudioVersion>12.0</VisualStudioVersion>
-  </PropertyGroup>
-  <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\$(WMSJSProjectDirectory)\Microsoft.VisualStudio.$(WMSJSProject).Default.props" />
-  <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\$(WMSJSProjectDirectory)\Microsoft.VisualStudio.$(WMSJSProject).props" />
-  <PropertyGroup>
-    <TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
-    <TargetPlatformVersion>8.1</TargetPlatformVersion>
-    <RequiredPlatformVersion>8.1</RequiredPlatformVersion>
-    <MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
-  </PropertyGroup>
-  <ItemGroup>
-    <AppxManifest Include="package.windows.appxmanifest">
-      <SubType>Designer</SubType>
-    </AppxManifest>
-    <Content Exclude="images\*SplashScreenPhone*;images\*.scale-240.*" Include="images\*.png" />
-    <Content Exclude="images\*SplashScreenPhone*;images\*.scale-240.*" Include="images\*.jpg" />
-    <Content Exclude="images\*SplashScreenPhone*;images\*.scale-240.*" Include="images\*.jpeg" />
-  </ItemGroup>
-  <ItemGroup>
-    <SDKReference Include="Microsoft.WinJS.2.0, Version=1.0" />
-  </ItemGroup>
-  <Import Project="CordovaApp.projitems" Label="Shared" />
-  <Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\$(WMSJSProjectDirectory)\Microsoft.VisualStudio.$(WMSJSProject).targets" />
-  <!-- To modify your build process, add your task inside one of the targets below then uncomment
-       that target and the DisableFastUpToDateCheck PropertyGroup.
-       Other similar extension points exist, see Microsoft.Common.targets.
-  <Target Name="BeforeBuild">
-  </Target>
-  <Target Name="AfterBuild">
-  </Target>
-  <PropertyGroup>
-    <DisableFastUpToDateCheck>true</DisableFastUpToDateCheck>
-  </PropertyGroup>
-  -->
-  <PropertyGroup>
-    <PreBuildEvent>node "$(ProjectDir)\\cordova\\prebuild-81.js"</PreBuildEvent>
-    <DisableFastUpToDateCheck>true</DisableFastUpToDateCheck>
-  </PropertyGroup>
-</Project>
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org