You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/04/17 00:04:43 UTC

Review Request: Do a simple check for required build tools.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/
-----------------------------------------------------------

Review request for mesos.


Description
-------

Do a simple check for required build tools.


Diffs
-----

  hadoop/TUTORIAL.sh f8131cd 

Diff: https://reviews.apache.org/r/10558/diff/


Testing
-------

Used in production at Airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Do a simple check for required build tools.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/#review19293
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On April 16, 2013, 10:04 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10558/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 10:04 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Do a simple check for required build tools.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
> 
> Diff: https://reviews.apache.org/r/10558/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Do a simple check for required build tools.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/#review19332
-----------------------------------------------------------



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/10558/#comment40011>

    Can you test against the exit code instead?


- Ben Mahler


On April 16, 2013, 10:04 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10558/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 10:04 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Do a simple check for required build tools.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
> 
> Diff: https://reviews.apache.org/r/10558/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Do a simple check for required build tools.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/#review19355
-----------------------------------------------------------



hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/10558/#comment40053>

    Can you make this consistent with the rest of the file, where we compare using this syntax:
    
    if test "$?" != 0; then


- Ben Mahler


On April 17, 2013, 11:16 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10558/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 11:16 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Do a simple check for required build tools.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
> 
> Diff: https://reviews.apache.org/r/10558/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Do a simple check for required build tools.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/#review19480
-----------------------------------------------------------


Thanks Brenden, can you mark this as submitted?

In the future, you can also subscribe to mesos-commits@incubator.apache.org if you want to actively mark your changes as submitted.

- Ben Mahler


On April 18, 2013, 12:54 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10558/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 12:54 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Do a simple check for required build tools.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
> 
> Diff: https://reviews.apache.org/r/10558/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Do a simple check for required build tools.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/#review19479
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 18, 2013, 12:54 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10558/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 12:54 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Do a simple check for required build tools.
> 
> 
> Diffs
> -----
> 
>   hadoop/TUTORIAL.sh f8131cd 
> 
> Diff: https://reviews.apache.org/r/10558/diff/
> 
> 
> Testing
> -------
> 
> Used in production at Airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Do a simple check for required build tools.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/
-----------------------------------------------------------

(Updated April 18, 2013, 12:54 a.m.)


Review request for mesos.


Description
-------

Do a simple check for required build tools.


Diffs (updated)
-----

  hadoop/TUTORIAL.sh f8131cd 

Diff: https://reviews.apache.org/r/10558/diff/


Testing
-------

Used in production at Airbnb.


Thanks,

Brenden Matthews


Re: Review Request: Do a simple check for required build tools.

Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10558/
-----------------------------------------------------------

(Updated April 17, 2013, 11:16 p.m.)


Review request for mesos.


Description
-------

Do a simple check for required build tools.


Diffs (updated)
-----

  hadoop/TUTORIAL.sh f8131cd 

Diff: https://reviews.apache.org/r/10558/diff/


Testing
-------

Used in production at Airbnb.


Thanks,

Brenden Matthews