You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/02/26 19:46:17 UTC
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/259
GUACAMOLE-269: Add fields for controlling Backspace behavior.
Client-side changes to allow the backspace key to be configured for SSH and Telnet sessions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-client GUACAMOLE-269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit da7c2f052d7f20eb2e5f9774f25774a42546ce30
Author: Nick Couchman <vn...@...>
Date: 2018-02-17T04:48:37Z
GUACAMOLE-269: Add fields for controlling Backspace behavior.
----
---
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/259#discussion_r178639552
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -447,6 +448,9 @@
"FIELD_HEADER_TYPESCRIPT_NAME" : "Typescript name:",
"FIELD_HEADER_TYPESCRIPT_PATH" : "Typescript path:",
+ "FIELD_OPTION_BACKSPACE_8" : "Backspace (Ctrl-H)",
+ "FIELD_OPTION_BACKSPACE_127" : "Delete (Ctrl-?)",
--- End diff --
These options are swapped compared to the telnet options. Which is correct?
---
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-client/pull/259
---
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/259#discussion_r178642851
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -447,6 +448,9 @@
"FIELD_HEADER_TYPESCRIPT_NAME" : "Typescript name:",
"FIELD_HEADER_TYPESCRIPT_PATH" : "Typescript path:",
+ "FIELD_OPTION_BACKSPACE_8" : "Backspace (Ctrl-H)",
+ "FIELD_OPTION_BACKSPACE_127" : "Delete (Ctrl-?)",
--- End diff --
You'll also need an entry for the `""` value (`FIELD_OPTION_BACKSPACE_EMPTY`).
---
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/259#discussion_r178640795
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -447,6 +448,9 @@
"FIELD_HEADER_TYPESCRIPT_NAME" : "Typescript name:",
"FIELD_HEADER_TYPESCRIPT_PATH" : "Typescript path:",
+ "FIELD_OPTION_BACKSPACE_8" : "Backspace (Ctrl-H)",
+ "FIELD_OPTION_BACKSPACE_127" : "Delete (Ctrl-?)",
--- End diff --
Fixed. SSH is correct - ASCII 8 is "Backspace", ASCII 127 is Del.
http://www.physics.udel.edu/~watson/scen103/ascii.html
---
[GitHub] guacamole-client pull request #259: GUACAMOLE-269: Add fields for controllin...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/259#discussion_r178643938
--- Diff: guacamole/src/main/webapp/translations/en.json ---
@@ -447,6 +448,9 @@
"FIELD_HEADER_TYPESCRIPT_NAME" : "Typescript name:",
"FIELD_HEADER_TYPESCRIPT_PATH" : "Typescript path:",
+ "FIELD_OPTION_BACKSPACE_8" : "Backspace (Ctrl-H)",
+ "FIELD_OPTION_BACKSPACE_127" : "Delete (Ctrl-?)",
--- End diff --
Added.
---