[GitHub] [flink] zhuzhurk commented on a change in pull request #10867: [FLINK-14701][runtime] Fix MultiTaskSlot to not remove slots which are not its children

[GitBox <gi...@apache.org>]

zhuzhurk commented on a change in pull request #10867: [FLINK-14701][runtime] Fix MultiTaskSlot to not remove slots which are not its children
URL: https://github.com/apache/flink/pull/10867#discussion_r370213639
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
 ##########
 @@ -612,7 +612,9 @@ private void releaseChild(AbstractID childGroupId) {
 				TaskSlot child = children.remove(childGroupId);
 
 				if (child != null) {
-					allTaskSlots.remove(child.getSlotRequestId());
+					if (child == allTaskSlots.get(child.getSlotRequestId())) {
+						allTaskSlots.remove(child.getSlotRequestId());
+					}
 
 Review comment:
   Yes I think it's better to have a check in master to help to expose the unexpected behavior.
   Thanks a lot for reviewing, improving and merging the changes!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services