You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/28 08:44:20 UTC

[jira] [Commented] (BEAM-599) Return KafkaIO getWatermark log in debug mode

    [ https://issues.apache.org/jira/browse/BEAM-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443073#comment-15443073 ] 

ASF GitHub Bot commented on BEAM-599:
-------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/incubator-beam/pull/900

    [BEAM-599] Return KafkaIO getWatermark log line in debug mode

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    KafkaIO getWatermark log line was removed in https://github.com/apache/incubator-beam/pull/859
    I actually found this log line useful, instead of removing it completely, returned this log line but change the log level to 'debug'?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/incubator-beam return-kafka-io-getwatermark-log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #900
    
----
commit 6742567a49e58abb44e9261f43baf73249a54647
Author: Aviem Zur <av...@gmail.com>
Date:   2016-08-28T08:41:58Z

    Returned KafkaIO getWatermark log line in debug mode

----


> Return KafkaIO getWatermark log in debug mode
> ---------------------------------------------
>
>                 Key: BEAM-599
>                 URL: https://issues.apache.org/jira/browse/BEAM-599
>             Project: Beam
>          Issue Type: Improvement
>            Reporter: Aviem Zur
>            Priority: Minor
>
> https://issues.apache.org/jira/browse/BEAM-574 removes the getWatermark log line from KafkaIO
> PR: https://github.com/apache/incubator-beam/pull/859
> I actually found this log line useful, instead of removing it completely can we return this log line but change the log level to 'debug'?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)