[GitHub] [ozone] elek commented on pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate

[GitBox <gi...@apache.org>]

elek commented on pull request #2499:
URL: https://github.com/apache/ozone/pull/2499#issuecomment-893258148


   Thank you to investigate this issue @smengcl 
   
   > In rare cases, applications will not seemingly trigger OzoneConfiguration#loadDefaults
   
   Can you please explain how this "rare" cases can happen?
   
   As far as I see, the `loadDefaults` is part of both the constructors with one exception:
   
   ```
       if (!(conf instanceof OzoneConfiguration)) {
          loadDefaults();
       }
   ``` 
   
   My main concern is this part. IF (!) the first line here false in these *rare* cases, it's not only a problem with `ozone-site.xml` but a problem with all the defaults coming from the fragmented XML files. Therefore, the patch couldn't fix all the problems: some defaults will be missing.
   
   Can you please check if this is case (as far as I understood the problem can be reproducible). We may need to fix the condition itself instead of adding the config to the defaults...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org