[jira] [Commented] (OLINGO-406) Adjust request metadata dependent on specified format

["Michael Bolz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117068#comment-14117068 ] 

Michael Bolz commented on OLINGO-406:
-------------------------------------

Hi [~ilgrosso],

thanks for mentioning this point.
I checked the fix and changed it that the type information is omitted if *no metadata* is set (e.g. {{if (StringUtils.isNotBlank(type) && format != ODataFormat.JSON_NO_METADATA)}}.
[~anthony.elliott]: Is this ok for our use case?
Then in the next step the *heuristically determination* as specified in [chapter 4.5.3|http://docs.oasis-open.org/odata/odata-json-format/v4.0/os/odata-json-format-v4.0-os.html#odataType] can be implemented.

Contributions are welcome.

Kind regards,
Michael

> Adjust request metadata dependent on specified format
> -----------------------------------------------------
>
>                 Key: OLINGO-406
>                 URL: https://issues.apache.org/jira/browse/OLINGO-406
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-client
>            Reporter: Anthony Elliott
>            Assignee: Michael Bolz
>         Attachments: metadata.diff
>
>
> If I changed the defaultPubFormat to be JSON (minimal metadata, OData 4 default) or JSON_NO_METADATA my requests were still sent with full metadata (which our server couldn't handle for some reason). Fixed by checking to see what format is being used before actually writing the metadata. I didn't cover all scenarios in testing, just what we needed, so use this as a starting point. There are likely some optimizations that I didn't bother trying to figure out for our limited scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)