You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 00:16:12 UTC

[GitHub] [helix] NealSun96 commented on pull request #1550: Controller-side Task Current State Migration

NealSun96 commented on pull request #1550:
URL: https://github.com/apache/helix/pull/1550#issuecomment-736132378


   @dasahcc As requested, I have trimmed down this PR: I removed all the non-essential changes, including REST and tools (utils) changes. 
   
   I kept both path building and controller logic change together. It doesn't make much sense for them to be separated. The controller change looks daunting, but it's actually just a refactor, so it's not very hard to review. Splitting it out would result too small of a PR. 
   
   Please let me know if this looks good. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org