[jira] [Commented] (HBASE-6832) [WINDOWS] Tests should use explicit timestamp for Puts, and not rely on implicit RS timing

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490236#comment-13490236 ] 

Ted Yu commented on HBASE-6832:
-------------------------------

For patch v4:
{code}
+   * @param initalAmount the inital value to start with
{code}
Typo: initalAmount -> initialAmount

For TestKeepDeletes:
{code}
+    EnvironmentEdgeManagerTestHelper.injectEdge(new IncrementingEnvironmentEdge(3000));
{code}
How was the value of 3000 chosen ?

                
> [WINDOWS] Tests should use explicit timestamp for Puts, and not rely on implicit RS timing  
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6832
>                 URL: https://issues.apache.org/jira/browse/HBASE-6832
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>              Labels: windows
>         Attachments: hbase-6832_v1-0.94.patch, hbase-6832_v1-trunk.patch, hbase-6832_v4-0.94.patch, hbase-6832_v4-trunk.patch
>
>
> TestRegionObserverBypass.testMulti() fails with 
> {code}
> java.lang.AssertionError: expected:<1> but was:<0>
> 	at org.junit.Assert.fail(Assert.java:93)
> 	at org.junit.Assert.failNotEquals(Assert.java:647)
> 	at org.junit.Assert.assertEquals(Assert.java:128)
> 	at org.junit.Assert.assertEquals(Assert.java:472)
> 	at org.junit.Assert.assertEquals(Assert.java:456)
> 	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass.checkRowAndDelete(TestRegionObserverBypass.java:173)
> 	at org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass.testMulti(TestRegionObserverBypass.java:166)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira