[GitHub] [nifi] markap14 commented on pull request #4804: NIFI-8181 - Added a property to specify whether to allow HTTP2 protoc…

[GitBox <gi...@apache.org>]

markap14 commented on pull request #4804:
URL: https://github.com/apache/nifi/pull/4804#issuecomment-772719837


   That's interesting @exceptionfactory. I didn't realize there were other additional protocols supported by the library. Personally I'm a bit torn on how I think we should best approach it. We can have a single property for specifying which protocols to support, but that has the downside that it's a bad user experience. It requires that the user look up the documentation each time to understand exactly what needs to be typed in, and must then type it in whereas the boolean approach allows them to just select the value (when it's appropriate). We could add an additional property for each protocol that that means we'd be adding several properties to a processor that already has *a lot* of properties.
   
   What it really comes down to, IMO, is a trade-off between power vs. ease of use. The boolean property is easier to use when it applies (which I think is going to be > 99% of the time) but is less powerful because it doesn't support the additional protocols. The other options are not as nice a user experience but are more powerful.
   
   Personally, I think we should lean more toward ease of use than power, so I think I prefer the boolean.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org