You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/07 18:33:55 UTC
[jira] Created: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
[classlib][pack200] regression: inner classes no longer computed correctly
--------------------------------------------------------------------------
Key: HARMONY-5585
URL: https://issues.apache.org/jira/browse/HARMONY-5585
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: Pack200 since HARMONY-5575
Reporter: Andrew Cornwall
Attachments: main.patch
In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
This had the unfortunate effect of removing references to all inner classes.
The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5585:
-------------------------------------
Attachment: test.patch
test.patch implements a unit test to make sure this doesn't regress again.
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Attachments: main.patch, test.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576986#action_12576986 ]
Sian January commented on HARMONY-5585:
---------------------------------------
Patches applied at r635551. Please check that they were applied as expected.
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch, test.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5585) [classlib][pack200] regression: inner
classes no longer computed correctly
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall closed HARMONY-5585.
------------------------------------
This patch was applied as expected. Thanks!
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch, test.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5585:
-------------------------------------
Attachment: main.patch
main.patch contains code changes implementing the fix.
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5585.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch, test.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5585) [classlib][pack200] regression:
inner classes no longer computed correctly
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5585:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] regression: inner classes no longer computed correctly
> --------------------------------------------------------------------------
>
> Key: HARMONY-5585
> URL: https://issues.apache.org/jira/browse/HARMONY-5585
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Pack200 since HARMONY-5575
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch, test.patch
>
>
> In my recent optimization of sorting (HARMONY-5575), I forgot that references to the sorted set would no longer be valid. The consequence of this is that ClassConstantPool.allClasses() always answered an empty ArrayList.
> This had the unfortunate effect of removing references to all inner classes.
> The attached patch corrects the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.