[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7685: Spark: Positional deletes creates unpartitioned path

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7685:
URL: https://github.com/apache/iceberg/pull/7685#discussion_r1202269896


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -435,7 +443,10 @@ public void delete(InternalRow metadata, InternalRow id) throws IOException {
 
       InternalRow partition = metadata.getStruct(partitionOrdinal, partitionRowWrapper.size());
       StructProjection partitionProjection = partitionProjections.get(specId);
-      partitionProjection.wrap(partitionRowWrapper.wrap(partition));
+
+      if (partitionProjection != null) {

Review Comment:
   I thought @stevenzwu already made the change that projections of null just return null, or did I remember that wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org