[GitHub] [ignite] zaleslaw commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas

[GitBox <gi...@apache.org>]

zaleslaw commented on a change in pull request #6853: IGNITE-12024: [ML] PeerClassloading for ml related lambdas
URL: https://github.com/apache/ignite/pull/6853#discussion_r321999275
 
 

 ##########
 File path: modules/ml/src/main/java/org/apache/ignite/ml/clustering/kmeans/KMeansModel.java
 ##########
 @@ -125,4 +128,9 @@ public DistanceMeasure distanceMeasure() {
             .addField("centroids", centersList)
             .toString();
     }
+
+    /** {@inheritDoc} */
+    @Override public List<Object> getDependencies() {
 
 Review comment:
   We need to start the something like "Template Trainer Design Document" based on parent class to describe the purpose of all these methods and hidden limitations of implementation like this method, what do you think, @avplatonov ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services