You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2026/07/17 15:01:54 UTC
[PR] Fix UnparsedEntityCheckingTest: remove leftover RuntimeException [xerces-j]
elharo opened a new pull request, #115:
URL: https://github.com/apache/xerces-j/pull/115
`testDefaultValid()` in `UnparsedEntityCheckingTest` had a leftover `throw new RuntimeException();` after `checkDefault()` at line 58, which caused the test to always fail with an error.
This was likely left over from development/debugging. Removed the throw statement so the test properly passes when validation succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] Fix UnparsedEntityCheckingTest: remove leftover RuntimeException [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #115:
URL: https://github.com/apache/xerces-j/pull/115#issuecomment-5004757583
Removed try-catch blocks from all test methods in response to review feedback. Exceptions now propagate naturally to JUnit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] Fix UnparsedEntityCheckingTest: remove leftover RuntimeException [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #115:
URL: https://github.com/apache/xerces-j/pull/115#discussion_r3604221952
##########
tests/schema/config/UnparsedEntityCheckingTest.java:
##########
Review Comment:
The try-catch can be removed. If an exception is thrown the test fails. No try-catch is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] Fix UnparsedEntityCheckingTest: remove leftover RuntimeException [xerces-j]
Posted by "lyca (via GitHub)" <gi...@apache.org>.
lyca commented on PR #115:
URL: https://github.com/apache/xerces-j/pull/115#issuecomment-5525508877
:+1: Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] Fix UnparsedEntityCheckingTest: remove leftover RuntimeException [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #115:
URL: https://github.com/apache/xerces-j/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org