[GitHub] [airflow] shubham22 commented on a diff in pull request #27823: Amazon Provider Package user agent

[GitBox <gi...@apache.org>]

shubham22 commented on code in PR #27823:
URL: https://github.com/apache/airflow/pull/27823#discussion_r1029876812


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -25,9 +25,13 @@
 from __future__ import annotations
 

Review Comment:
   >     1. Someone of end users might be unhappy the fact that we actually started collect additional telemetry like.
   >        dag_id and ClassName even if it only hashes. So might be better collect by default only Airflow and Amazon Provider version and if required additional metadata then call optional callable which could controlled by config e.g. `[aws] extra_botocore_user_agent_callable` with full qualified path to callable e.g. `some_vendor.safe.get_user_agent`
   
   While I understand where you're coming from, I disagree with this on multiple aspects - 
   1. Hashed Id doesn't really give us any information about what a user could be naming. It is completely private, and doesn't incur any cost. It rather allows us to make better decisions on our end to serve the users better. If it wasn't hashed, I would agree with your suggestion.
   
   2. No more additional configs, please. We already give a lot of configs to the users, and we should try to minimize the overuse. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org