Re: [PR] fix(embedded): guest token expiration should be in seconds not milliseconds [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #18891:
URL: https://github.com/apache/superset/pull/18891#issuecomment-2297865605

   @ygelfand are you still able/willing to get this across the finish line? Sorry there hasn't been much activity here. I'll go ahead and set the PR to draft, but you can mark it as ready for review after a rebase takes place, which should also kick-start CI. 
   
   I also wonder, would this change meant that when people update, they need to change their config from milliseconds to seconds? If so, we should put an entry in UPDATING.md, and probably consider it a breaking change (if it would cause issues if people don't change their setting)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org