You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "withnale (via GitHub)" <gi...@apache.org> on 2025/03/14 13:34:24 UTC
[PR] Spare import2 [superset]
withnale opened a new pull request, #32670:
URL: https://github.com/apache/superset/pull/32670
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32670:
URL: https://github.com/apache/superset/pull/32670#issuecomment-2725807895
I was unable to post the issues I found. This could be because a force push or squash has changed the commit history since I scanned this pull request. You can get another review by commenting `/korbit-review`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #32670:
URL: https://github.com/apache/superset/pull/32670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32670:
URL: https://github.com/apache/superset/pull/32670#discussion_r1996435791
##########
superset/importexport/api.py:
##########
@@ -177,6 +177,7 @@ def import_(self) -> Response:
if not contents:
raise NoValidFilesFoundError()
+ sparse = request.form.get("sparse") == "true"
Review Comment:
Thank you for pointing that out. However, maintaining consistency with how it was being done across other import APIs was a conscious choice while implementing this. Your suggestion can be a future enhancement to improve the robustness. Also we could take this up as a separate refactor task across the parts of codebase where we are making similar parsing. Sounds good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "withnale (via GitHub)" <gi...@apache.org>.
withnale commented on PR #32670:
URL: https://github.com/apache/superset/pull/32670#issuecomment-2727664621
/korbit-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Spare import2 [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32670:
URL: https://github.com/apache/superset/pull/32670#issuecomment-2724730229
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32670:
URL: https://github.com/apache/superset/pull/32670#discussion_r1996420476
##########
superset/commands/importers/v1/assets.py:
##########
@@ -79,12 +82,29 @@
kwargs.get("ssh_tunnel_priv_key_passwords") or {}
)
self._configs: dict[str, Any] = {}
+ self.sparse = kwargs.get("sparse", False)
# pylint: disable=too-many-locals
@staticmethod
- def _import(configs: dict[str, Any]) -> None: # noqa: C901
+ def _import(configs: dict[str, Any], sparse: bool = False) -> None: # noqa: C901
# import databases first
database_ids: dict[str, int] = {}
+ dataset_info: dict[str, dict[str, Any]] = {}
+ chart_ids: dict[str, int] = {}
+
+ if sparse:
+ existing_charts = db.session.query(Slice).all()
+ existing_datasets = db.session.query(SqlaTable).all()
+ existing_databases = db.session.query(Database).all()
+ chart_ids = {str(x.uuid): x.id for x in existing_charts}
+ database_ids = {str(x.uuid): x.id for x in existing_databases}
Review Comment:
### Inefficient bulk loading in sparse mode <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The sparse import functionality queries all existing charts, datasets, and databases, which could lead to performance issues with large databases.
###### Why this matters
Loading all records into memory at once for large installations could cause excessive memory usage and slow down the import process.
###### Suggested change ∙ *Feature Preview*
Use batched queries to load records in chunks and implement a lookup mechanism. Example:
```python
def get_existing_items_batched(model_class, batch_size=1000):
offset = 0
mapping = {}
while True:
batch = db.session.query(model_class).limit(batch_size).offset(offset).all()
if not batch:
break
mapping.update({str(x.uuid): x.id for x in batch})
offset += batch_size
return mapping
if sparse:
chart_ids = get_existing_items_batched(Slice)
database_ids = get_existing_items_batched(Database)
dataset_info = {}
for dataset in get_existing_items_batched(SqlaTable):
dataset_info[str(dataset.uuid)] = {
"datasource_id": dataset.id,
"datasource_type": dataset.datasource_type,
"datasource_name": dataset.datasource_name,
}
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7aafef91-04ea-4a94-b999-8dfbc0f336f0?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:c791c099-da99-42f5-bc8a-8af1e6298894 -->
##########
superset/importexport/api.py:
##########
@@ -177,6 +177,7 @@ def import_(self) -> Response:
if not contents:
raise NoValidFilesFoundError()
+ sparse = request.form.get("sparse") == "true"
Review Comment:
### Brittle Boolean Parsing <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The code uses string comparison ("true") for determining the sparse parameter value, which can be error-prone and miss other valid boolean representations.
###### Why this matters
This strict string comparison could cause the sparse functionality to fail if clients send variations like 'True', '1', or other valid boolean representations, leading to unexpected import behavior.
###### Suggested change ∙ *Feature Preview*
Use a more robust boolean parsing method that handles various truthy values:
```python
def parse_boolean(value):
if isinstance(value, bool):
return value
if isinstance(value, str):
value = value.lower()
if value in ('true', 't', '1', 'yes', 'y'):
return True
if value in ('false', 'f', '0', 'no', 'n'):
return False
return False
sparse = parse_boolean(request.form.get("sparse"))
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/cdb3f938-6040-476a-8a7f-dc7990c777b5?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:bb304b23-8333-4ae1-b969-cabfa760fb1a -->
##########
superset/commands/importers/v1/assets.py:
##########
@@ -79,12 +82,29 @@
kwargs.get("ssh_tunnel_priv_key_passwords") or {}
)
self._configs: dict[str, Any] = {}
+ self.sparse = kwargs.get("sparse", False)
# pylint: disable=too-many-locals
@staticmethod
- def _import(configs: dict[str, Any]) -> None: # noqa: C901
+ def _import(configs: dict[str, Any], sparse: bool = False) -> None: # noqa: C901
Review Comment:
### Missing parameter documentation in _import method <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The `sparse` parameter is not documented despite being a significant behavior flag.
###### Why this matters
Without understanding what 'sparse' does, developers may misuse this parameter, leading to unexpected import behavior.
###### Suggested change ∙ *Feature Preview*
@staticmethod
def _import(configs: dict[str, Any], sparse: bool = False) -> None: # noqa: C901
"""Import all the assets from the configs.
Args:
configs: The configuration dictionary for assets
sparse: When True, uses existing assets (charts, datasets, databases) instead of recreating them
"""
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/70f2d925-c73c-4bc2-9760-1f797fd998c0?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:bf9da407-6b5e-416f-ad3c-df9f6eddfd12 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #32670:
URL: https://github.com/apache/superset/pull/32670#issuecomment-2725992343
/korbit-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Implement sparse import for ImportAssetsCommand [superset]
Posted by "withnale (via GitHub)" <gi...@apache.org>.
withnale commented on code in PR #32670:
URL: https://github.com/apache/superset/pull/32670#discussion_r1996435649
##########
superset/importexport/api.py:
##########
@@ -177,6 +177,7 @@ def import_(self) -> Response:
if not contents:
raise NoValidFilesFoundError()
+ sparse = request.form.get("sparse") == "true"
Review Comment:
I copied this exact approach from how the overwrite parsing was being done on the other import APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Spare import2 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #32670:
URL: https://github.com/apache/superset/pull/32670#issuecomment-2724757551
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/32670?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `75.00000%` with `10 lines` in your changes missing coverage. Please review.
> Project coverage is 76.15%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d0ed6b1`)](https://app.codecov.io/gh/apache/superset/commit/d0ed6b1a83f7feee5aaad0995c364cf1a79974ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1601 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/32670?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/commands/importers/v1/assets.py](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&filepath=superset%2Fcommands%2Fimporters%2Fv1%2Fassets.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2Fzc2V0cy5weQ==) | 56.25% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...uperset/commands/dashboard/importers/dispatcher.py](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&filepath=superset%2Fcommands%2Fdashboard%2Fimporters%2Fdispatcher.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGFzaGJvYXJkL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...perset/commands/dashboard/importers/v1/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&filepath=superset%2Fcommands%2Fdashboard%2Fimporters%2Fv1%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGFzaGJvYXJkL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | 93.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/importexport/api.py](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&filepath=superset%2Fimportexport%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvaW1wb3J0ZXhwb3J0L2FwaS5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/32670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #32670 +/- ##
===========================================
+ Coverage 60.48% 76.15% +15.66%
===========================================
Files 1931 549 -1382
Lines 76236 39431 -36805
Branches 8568 0 -8568
===========================================
- Hits 46114 30027 -16087
+ Misses 28017 9404 -18613
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <25.00%> (-0.73%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.75% <75.00%> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.92% <25.00%> (-0.88%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.15% <75.00%> (+12.66%)` | :arrow_up: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.27% <75.00%> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/32670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/32670?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- 📦 [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org