You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/01 20:03:28 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7766: Clean up HTTP version processing

SolidWallOfCode commented on a change in pull request #7766:
URL: https://github.com/apache/trafficserver/pull/7766#discussion_r624558222



##########
File path: proxy/hdrs/HTTP.h
##########
@@ -700,29 +696,42 @@ class HTTPHdr : public MIMEHdr
 /*-------------------------------------------------------------------------
   -------------------------------------------------------------------------*/
 
-inline HTTPVersion::HTTPVersion(int32_t version) : m_version(version) {}
+inline HTTPVersion::HTTPVersion(int version)
+{
+  vmajor = (version & 0xFFFF0000) >> 16;

Review comment:
       It looks more consistent with the next line, and avoids any issues with the sign bit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org